2002206 - [Linux] Remove compositor destroy on widget unmap

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, task, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1997782#c11 - let's remove this Linux specific hack.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2002206 [Linux] Don't delete layer manager for hidden popups r?emilio

Linux used a workaround for Bug 1654938 but let's remove it and follow other platforms there.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The compositor destroy is synced so may cause UI delays on popup unmap, I hope for better full async rendering to wl_surface on wayland without compositor freezes / ui freezes etc here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b13e90b6db83
https://hg.mozilla.org/integration/autoland/rev/ae4fb91c0c3c
[Linux] Don't delete layer manager for hidden popups r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60b4755b5fd5
https://hg.mozilla.org/integration/autoland/rev/934445f9032a
Revert "Bug 2002206 [Linux] Don't delete layer manager for hidden popups r=emilio" for causing mochitest failures @test_bug1969341.html.

Comment 5

[agoloman]

Backed out for causing mochitest failures @test_bug1969341.html.

• Backout link
• Push with failures
• Failure Log
• Failures Log @test_password_length.html

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Looks like the failure is Wayland only.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Okay, let's leave it here as is.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Will look at it eventually anyway.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Applied on top of Bug 2001628 and try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=172039
Let's see if the failure is still here.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

New try with fixed build: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=172345