1739232 - [Linux] Implement async rendering to unmapped wl_surface

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Always return valid NS_NATIVE_WINDOW/NS_NATIVE_WIDGET/NS_NATIVE_WINDOW_WEBRTC_DEVICE_ID.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1737068

Comment 2

[Pascal Chevrel:pascalc]

Martin, is that something we should track for an uplift in 95 or can the fix ride the trains when it happens? Thanks

Comment 3

[Martin Stránský [:stransky] (ni? me)]

No need to track, I have to diagnose if and when this affects recent builds first.
I don't have info about recent crashes caused by this one.

Comment 4

[Pascal Chevrel:pascalc]

Thanks

Comment 5

[:gerard-majax]

From comment 3 I would assume there's no crash about this?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

We may keep wl_surface valid after unmap (just remove wl_subsurface role) and not suspend/resume compositor for it. It allows to avoid synced calls to compositor and we can always return valid GL window (but hidden).

Comment 7

[Martin Stránský [:stransky] (ni? me)]

No need to track, we don't crash here.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: WIP: Bug 1739232 [Wayland] Implement async rendering to WaylandSurface

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=159996

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Let's submit it as separated patches for better reviews and regression handling.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

As a part of this bug we may also enable Vsync ASAP for toplevel window to start painting early as possible (Bug 2002237).