2002276 - Searching for "1 row" in Settings redesign will not highlight the results

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: 1 row search in settings.png

Found in

• Firefox 147.0a1 (2025-11-24)

Affected versions

• Firefox 147.0a1 (2025-11-24)

Tested platforms

• Affected platforms: macOS 26.1, Windows 11, Ubuntu 24.04

Preconditions

• Have the following pref on True:
  browser.settings-redesign.enabled

Steps to reproduce

1. Access about:preferences#home
2. Click on Search (or ctrl/cmd+F)
3. Search for "1 row"

Expected result

• The "1 row" strings are highlighted

Actual result

• The "1 row" strings are not highlighted

Regression range

• New feature

Additional notes

• The issue can be seen in the attachment.

Comment 1

[Mark Striemer [:mstriemer]]

It seems likely that we aren't finding the correct anchor position since this tooltip would be matching the <option> element within the <moz-select>, we calculate the position here https://searchfox.org/firefox-main/rev/965f7176dd09e26daca9efbfdf23dce16da43e97/browser/components/preferences/findInPage.js#738

Comment 2

[Amber Meryman]

Is this an issue for all drop-down lists in the Settings Redesign? Wondering if it's on the New Tab team to resolve so that these can be found via Search.

Comment 3

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: home and startup search no popup.png

I think so, it seems that this happens for multiple items when searching, for example (default) / Blank Page / Custom URL, which can be found in dropdowns.

Comment 4

[akulyk]

Attachment: Bug 2002276 - Searching for "1 row" in Settings redesign will not highlight the results r=#recomp-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8862b908a2ee
https://hg.mozilla.org/integration/autoland/rev/20c87bda3693
Searching for "1 row" in Settings redesign will not highlight the results r=hjones

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b85eebff428
https://hg.mozilla.org/mozilla-central/rev/d2df02482fa8
Searching for "1 row" in Settings redesign will not highlight the results r=hjones

Comment 7

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/d2df02482fa8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something you wanted to nominate for Release uplift?

Comment 9

[akulyk]

I believe it's OK for this fix to arrive in 153