2002809 - Incorrect Desktop shortcut name created when enabling shortcut for a copied switchable profile

Status: RESOLVED INVALID

(Toolkit :: Startup and Profile System, defect)

Description

[Simona Badau, Desktop Test Engineering]

Attachment: Screencast with the issue

Found in

• Firefox 146.0b8

Affected versions

• Firefox 146.0b8

Tested platforms

• Affected platforms: Windows 11 x64

Preconditions

• Ensure that ProfileA and ProfileB are created in the Profile Manager using -p (regular profiles, not switchable).
• In ProfileA: create a switchable profile named Personal, and create a Desktop shortcut for it.
• In ProfileB: create a switchable profile named Personal, but do NOT create a Desktop shortcut.

Steps to reproduce

1. Launch ProfileB -> open the Hamburger menu and open the Personal profile.
2. Copy this Profile.
3. In the about:editprofile#copiedProfileName=Personal page toggle the Desktop Shortcut option.

Expected result

• A new Desktop shortcut named Profile 2 should be created.

Actual result

• Personal(1) shortcut is created. If the Desktop Shortcut option is toggled off and then toggled on again, the correct behavior occurs and a Profile 2 shortcut is created.

Regression range

• This is not a regression.

Additional notes

• I'm not being able to reproduce this issue on Nightly 147.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I believe this is working as expected.

To avoid possible desktop shortcut filename collisions, we use the same code that chooses a name for files downloaded by Firefox. So, if there are two profiles on a system with the same name, and both of them create a desktop shortcut, we would expect the shortcut name to have "(1)" or "(2)", etc., appended to the end of the shortcut name.