Closed Bug 2003294 Opened 11 months ago Closed 10 months ago

Clean up messages in ContentSearchParent following content search UI changes

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [sng])

Attachments

(2 external files)

Following on from the changes in bug 1999334 and bug 2002027 we can remove some of the messages that are handled in ContentSearchParent.

Additionally, we can also simplify how the GetEngine message is sent (which will avoid us getting some engines/icons on startup until we really need them), and also rename the isPrivateEngine property of the message to make it clearer.

Pushed by mbanner@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8943ca67c923 https://hg.mozilla.org/integration/autoland/rev/1c4a622986a7 Remove now unnecessary messages from ContentSearchParent. r=search-reviewers,scunnane https://github.com/mozilla-firefox/firefox/commit/aca14b8e6715 https://hg.mozilla.org/integration/autoland/rev/0eb9f87f9eef Simplify GetEngine message in ContentSearchParent, and remove the need for all messages to await the search service. r=search-reviewers,scunnane
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
QA Whiteboard: [search] [qa-triage-done-c149/b148]

Hey Mark, these patches unfortunately do not back out cleanly. Do you have some upcoming time where they could be backed out, either here, or in a separate bug? This is to perform the work in bug 2017049 to temporarily restore the non-handoff capability.

Flags: needinfo?(standard8)
Blocks: 2018257
Flags: needinfo?(standard8)
No longer blocks: 2018257
See Also: → 2018257

Should this be reopened since it the code was reverted in bug 2018257?

Blocks: 2018257

(In reply to Mathew Hodson from comment #6)

Should this be reopened since it the code was reverted in bug 2018257?

No. This landed and at least went to beta.

See Also: 2018257 →
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: