2002027 - Make handoff searchbar a self-contained reusable component

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

While some of the handoff searchbar's logic is somewhat self-contained (via the ContentSearchHandoffUIController), the markup for the search input, and handling the actual handoffs is up to the embedders (this happens in Search.jsx / PlacesFeed for newtab and aboutPrivateBrowsing.js / AboutPrivateBrowsingParent for about:privatebrowsing).

Ideally, this whole thing would be self-contained and have a single implementation for the handoff behaviour. We should still, however, allow the handoff bar to be custom-styled for each embed point.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2002027 - Part 1: Make contentSearchHandoffUI a module.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2002027 - Part 2: Add ContentSearchHandoffUI component and styling, and embed in about:newtab.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2002027 - Part 3: Embed ContentSearchHandoffUI component into about:privatebrowsing.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/705736c7f354
https://hg.mozilla.org/integration/autoland/rev/77faf5a74ff0
Part 1: Make contentSearchHandoffUI a module. r=search-reviewers,home-newtab-reviewers,Standard8,nbarrett
https://github.com/mozilla-firefox/firefox/commit/8b6a7f8464a6
https://hg.mozilla.org/integration/autoland/rev/02dad5b69a9c
Part 2: Add ContentSearchHandoffUI component and styling, and embed in about:newtab. r=search-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,places-reviewers,frontend-codestyle-reviewers,nbarrett
https://github.com/mozilla-firefox/firefox/commit/a0c4551d89f1
https://hg.mozilla.org/integration/autoland/rev/9f31305ac777
Part 3: Embed ContentSearchHandoffUI component into about:privatebrowsing. r=desktop-theme-reviewers,Standard8,urlbar-reviewers,emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c71cdfa065c
https://hg.mozilla.org/integration/autoland/rev/a2d99a10baa0
Revert "Bug 2002027 - Part 3: Embed ContentSearchHandoffUI component into about:privatebrowsing. r=desktop-theme-reviewers,Standard8,urlbar-reviewers,emilio" for causing bc failures in browser_urlbar_telemetry_searchmode.js DONTBUILD

Comment 6

[Cristian Tuns]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_urlbar_telemetry_searchmode.js | searchMode should exist on moz-urlbar - false == true -

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99e19f8eb4a3
https://hg.mozilla.org/integration/autoland/rev/7fec3665a189
Part 1: Make contentSearchHandoffUI a module. r=search-reviewers,home-newtab-reviewers,Standard8,nbarrett
https://github.com/mozilla-firefox/firefox/commit/a4f1dd377083
https://hg.mozilla.org/integration/autoland/rev/47808257ada3
Part 2: Add ContentSearchHandoffUI component and styling, and embed in about:newtab. r=search-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,places-reviewers,frontend-codestyle-reviewers,nbarrett
https://github.com/mozilla-firefox/firefox/commit/56c1486eec04
https://hg.mozilla.org/integration/autoland/rev/04bcf664cff7
Part 3: Embed ContentSearchHandoffUI component into about:privatebrowsing. r=desktop-theme-reviewers,Standard8,urlbar-reviewers,emilio

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7fec3665a189
https://hg.mozilla.org/mozilla-central/rev/47808257ada3
https://hg.mozilla.org/mozilla-central/rev/04bcf664cff7