2003434 - bookmarking any website results in an invalid URL error

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, defect)

Description

[Jon]

Attachment: can't bookmark even Google, all urls produce same error

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:145.0) Gecko/145.0 Firefox/145.0

Steps to reproduce:

In Firefox on Android 145, tap the triple dot menu and tap bookmark page on any website with a bookmarkable URL.

Actual results:

All websites return a "invalid URL" error.

Expected results:

A bookmark created in the last folder a bookmark was created in of the URL I attempted to bookmark.

Comment 1

[Jon]

Disabled all extensions and reattempted to make a bookmark, error still occurs.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Matt Tighe [:matt-tighe]]

Hi there, thanks for the report! I'm not able to reproduce this on nightly or release, so I'm tagging QA to see if they have better luck. Thanks for your help QA!

Looking at the code path, my first guess would be that there's an error in how we are saving the "last folder" the bookmark was created in. :Jon, could you try creating a new folder through the bookmarks screen first, and then saving a new bookmark from the browser screen?

Comment 4

[Matt Tighe [:matt-tighe]]

For future debugging:

We display this error from here, which means we have an unexpected null reference coming from here

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Seems like this would also happen if the previously saved folder was deleted?

Comment 6

[Jon]

I created a subfolder called test in the bookmarks menu folder then tried to bookmark google.com again and got the invalid URL error once more. I then deleted the test folder and recreated it in the same place and bookmarked Google, and the bookmarking function started working again. It is defaulting to the bookmarks folder but I can edit it from there.

Comment 7

[Adina Petridean QA [:apetridean]]

Hello! We weren’t able to reproduce this issue on the latest Nightly 148.0a1 (12.22.2025), Fenix 147.0b7, RC 146.0.1, or 145, using Google Pixel 10 (Android 16) and Samsung Galaxy S23 Ultra (Android 14).
@Jon, could you please share the device you used when reproducing this issue? Also, could you try to check whether the issue still reproduces on the latest Nightly with a fresh install?

Comment 8

[Jon]

(In reply to Adina Petridean QA [:apetridean] from comment #7)

Hello! We weren’t able to reproduce this issue on the latest Nightly 148.0a1 (12.22.2025), Fenix 147.0b7, RC 146.0.1, or 145, using Google Pixel 10 (Android 16) and Samsung Galaxy S23 Ultra (Android 14).
@Jon, could you please share the device you used when reproducing this issue? Also, could you try to check whether the issue still reproduces on the latest Nightly with a fresh install?

Samsung Galaxy S23 Ultra SM-918U1
Firefox 146.0.1 (Build #2016132551), 86bb7f6af6312ba3c0161085f854bcdff68f1a91
GV: 146.0.1-20251217121356
AS: 146.0.2
OS: Android 16

Error cannot be reproduced on my stable version after having created, deleted, and recreated a folder as mentioned above. I installed nightly 148.0a1 (Build #2016133663) and cannot reproduce the error using that build.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 11

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 2003434 - don't try and save a bookmark to an invalid folder. r=matt-tighe

Comment 12

[Mark Hammond [:markh] [:mhammond]]

STR:

• Successfully save a bookmark in a custom folder.
• Delete that folder.
• Try and create a new bookmark with the star icon on the menu - it will try and save it in the now-deleted folder.

Comment 13

[Segun Famisa [:segun]]

Thanks Mark for the investigation and your patch. I'll take over this bug and add the tests

Comment 14

[Segun Famisa [:segun]]

Attachment: GitHub Pull Request

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cab6a911a185
https://hg.mozilla.org/integration/autoland/rev/dcad8a3e9c9b
Fallback to mobile bookmarks root if last saved folder does not exist r=boek

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ead92add275
https://hg.mozilla.org/integration/autoland/rev/611d56005177
Revert "Bug 2003434 - Fallback to mobile bookmarks root if last saved folder does not exist r=boek" for causing failures at MenuDialogMiddlewareTest.

Comment 17

[Atila Butkovits]

Backed out for causing failures at MenuDialogMiddlewareTest.

Backout link: https://hg.mozilla.org/integration/autoland/rev/611d56005177

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=dcad8a3e9c9b06e7f724d982c08a9f5b14e7da1b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=544997168&repo=autoland&task=AS7l5z5fR8GVSq3Biks7kw.0&lineNumber=5353

Comment 18

[BMO Github Automation]

Attachment: [mozilla-firefox/firefox] Bug 2003434 - Fallback to mobile bookmarks root if last saved folder does not exist (#38)

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e02a3c82066e
https://hg.mozilla.org/integration/autoland/rev/beda53049aad
Fallback to mobile bookmarks root if last saved folder does not exist r=matt-tighe

Comment 20

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/beda53049aad