2003877 - Remove contentSearchHandoffUI.css from stylelint exception list

Status: NEW

(Firefox :: Search, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 2002027 introduced contentSearchHandoffUI.css, which centralized a bunch of CSS rules that were being used for the handoff search bar across about:newtab and about:privatebrowsing.

On its own, this new contentSearchHandoffUI.css file doesn't actually pass the stylelint checks. Here are the failures:

  47:3  error  var(--content-search-handoff-ui-background-color) var(--newtab-search-icon) 16px center no-repeat should use a background-color design token.                                           stylelint-plugin-mozilla/use-background-color-tokens (stylelint)
  54:3  error  var(--content-search-handoff-ui-border-width) solid var(--content-search-handoff-ui-unfocused-border-color) should use a border-color design token.                                     stylelint-plugin-mozilla/use-border-color-tokens (stylelint)
  56:3  error  var(--content-search-handoff-ui-color) should use a text-color design token.                                                                                                            stylelint-plugin-mozilla/use-text-color-tokens (stylelint)
  79:3  error  var(--content-search-handoff-ui-caret-color) should use a background-color design token.                                                                                                stylelint-plugin-mozilla/use-background-color-tokens (stylelint)
  81:3  error  Consider using a size design token instead of calc(2 * var(--space-xlarge)). This may be fixable by running the same command again with --fix.                                          stylelint-plugin-mozilla/use-size-tokens (stylelint)
  82:3  error  Consider using a size design token instead of 1px. This may be fixable by running the same command again with --fix.                                                                    stylelint-plugin-mozilla/use-size-tokens (stylelint)
  87:3  error  Consider using a size design token instead of 17px. This may be fixable by running the same command again with --fix.                                                                   stylelint-plugin-mozilla/use-size-tokens (stylelint)
  88:3  error  -17px should be using a space design token.                                                                                                                                             stylelint-plugin-mozilla/use-space-tokens (stylelint)
  92:3  error  var(--content-search-handoff-ui-border-width) solid var(--content-search-handoff-ui-fakefocus-border-color) should use a border-color design token.                                     stylelint-plugin-mozilla/use-border-color-tokens (stylelint)
  93:3  error  0 0 0 2px var(--content-search-handoff-ui-fakefocus-box-shadow-inner),
    0 0 0 4px var(--content-search-handoff-ui-fakefocus-box-shadow-outer) should use a box-shadow design token.  stylelint-plugin-mozilla/use-box-shadow-tokens (stylelint)

So we'll want to go through this list of stylelint failures and figure out where it makes sense to fix, or to add line-by-line exceptions. It may come to pass that this file gets removed before we get to this (with the multi-context address bar eventually replacing this component and stylesheet), and if so, we can just close this bug.