Closed Bug 2004428 Opened 7 months ago Closed 7 months ago

Align App Bar XML styles with the M3 specs

Categories

(Firefox for Android :: Design System and Theming, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
147 Branch
Tracking Status
firefox147 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] [group5])

Attachments

(3 files)

Adjust ToolbarTitleTextStyle to match the text style for the app bar in the latest M3 specs. This is the XML style that is used for all of the app bars for our existing XML screens.

The task is to add a Headline5 XML style and use that as the base for ToolbarTitleTextStyle.

Figma: https://www.figma.com/design/MjufE1X5fvkxZ0YneX4kRd/Android-Library--2025-?node-id=61795-11260&m=dev

Whiteboard: [fxdroid] [group5]
  • This aligns the edit mode colors for the app bar between the History, Bookmarks and Downloads screen.
  • Fixes the usage of inverseOnSurface to onPrimary. These are the same colors, but semantically using onPrimary on Primary has a better flow.
  • Follow up bug to be filed is to remove all of these edit mode colors because that will be going away with the M3 specs update. For now, we are just aligning the colors so the screens will look unified.
Pushed by gluong@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/82f18622d603 https://hg.mozilla.org/integration/autoland/rev/e6f67621fc3e Part 1: Align App Bar XML styles with the M3 specs r=android-reviewers,007 https://github.com/mozilla-firefox/firefox/commit/d52424327320 https://hg.mozilla.org/integration/autoland/rev/f024eccb7381 Part 2: Replace ic_back_button drawable with mozac_ic_back_24 r=android-reviewers,007 https://github.com/mozilla-firefox/firefox/commit/4647a493653b https://hg.mozilla.org/integration/autoland/rev/c919f4a801f9 Part 3: Align the History app bar edit mode colors with the Bookmarks and Downloads screen r=android-reviewers,007
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Regressions: 2004703
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: