2005078 - Replace button.footer-button with moz-buttons

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Mark Striemer [:mstriemer]]

The footer-button class provides styling for XUL buttons to look like our moz-button component. These look like they could be replaced with moz-button directly now

• Searching for [^-]\bfooter-button\b seems to find a good starting list Searchfox
• button.footer-button[default] and button.footer-button.primary should be moz-button[type="primary"]
• button.footer-button.small-button should be moz-button[size="small"]
• button.footer-button[type="menu"] should not be converted yet (will file a follow-up)
• In .xhtml files, we will need to specify the markup for moz-button as <html:moz-button>
• Changes should be made in parts, with one commit per directory (browser/base/content, browser/components/customizableui/content, browser/components/translations/content, etc)
• Be sure to create a try build and check for test failures, there could be queries on the footer-button class or button.some-class that need to be updated

Comment 1

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/base/content/ r=#reusable-components-reviewers-rotation

Comment 2

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/customizableui/ r=#reusable-components-reviewers-rotation

Comment 3

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/downloads/ r=#reusable-components-reviewers-rotation

Comment 4

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/remotecontrol/ r=#reusable-components-reviewers-rotation

Comment 5

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/reportbrokensite/ r=#reusable-components-reviewers-rotation

Comment 6

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/screenshots/ r=#reusable-components-reviewers-rotation

Comment 7

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in browser/components/translations/ r=#reusable-components-reviewers-rotation

Comment 8

[oarnesto]

Attachment: Bug 2005078 - Replace button.footer with moz-button in toolkit/content/widgets/ r=#reusable-components-reviewers-rotation

Comment 9

[oarnesto]

Attachment: Bug 2005078 - Remove unused .footer-button CSS r=#reusable-components-reviewers-rotation

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e3a79ab92465
https://hg.mozilla.org/integration/autoland/rev/2ae1c628a123
Replace button.footer with moz-button in browser/base/content/ r=places-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/a35301b6717c
https://hg.mozilla.org/integration/autoland/rev/7a28769bc11a
Replace button.footer with moz-button in browser/components/customizableui/ r=desktop-theme-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/1ec153273d53
https://hg.mozilla.org/integration/autoland/rev/3336c1143ced
Replace button.footer with moz-button in browser/components/downloads/ r=akulyk
https://github.com/mozilla-firefox/firefox/commit/88ba12b7b3c8
https://hg.mozilla.org/integration/autoland/rev/02886e2762ca
Replace button.footer with moz-button in browser/components/remotecontrol/ r=akulyk,desktop-theme-reviewers
https://github.com/mozilla-firefox/firefox/commit/dfa673c9a8df
https://hg.mozilla.org/integration/autoland/rev/9295a634f77f
Replace button.footer with moz-button in browser/components/reportbrokensite/ r=desktop-theme-reviewers,webcompat-reviewers,akulyk,twisniewski
https://github.com/mozilla-firefox/firefox/commit/60e3e480f4ed
https://hg.mozilla.org/integration/autoland/rev/432a2996e996
Replace button.footer with moz-button in browser/components/translations/ r=translations-reviewers,akulyk,desktop-theme-reviewers,nordzilla
https://github.com/mozilla-firefox/firefox/commit/f112fd560d25
https://hg.mozilla.org/integration/autoland/rev/3fe9380aba46
Replace button.footer with moz-button in toolkit/content/widgets/ r=reusable-components-reviewers,omc-reviewers,akulyk,emcminn,media-playback-reviewers,urlbar-reviewers,nimbus-reviewers,jteow,padenot,sachung
https://github.com/mozilla-firefox/firefox/commit/474df7e6aab7
https://hg.mozilla.org/integration/autoland/rev/cd2ec7b01774
Remove unused .footer-button CSS r=desktop-theme-reviewers,akulyk

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa1e90ea670c
https://hg.mozilla.org/integration/autoland/rev/ab3ff1cb2d01
Revert "Bug 2005078 - Remove unused .footer-button CSS r=desktop-theme-reviewers,akulyk" for causing mda-bc failures at browser_decoderDoctor.js

Comment 12

[Silaghi Andreea]

Backed out for causing mda-bc failures at browser_decoderDoctor.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-PASS | dom/media/doctor/test/browser/browser_decoderDoctor.js | test_decode_error - notification button should have accesskey - Got "R", expected "R"

Comment 13

[Silaghi Andreea]

Also multiple bc tests failures -- here

Comment 14

[oarnesto]

Failure line TEST-UNEXPECTED-PASS | dom/media/doctor/test/browser/browser_decoderDoctor.js | test_decode_error - notification button should have accesskey - Got "R", expected "R"

This at least was caused by a test I forgot to change from a todo_is() back to an is() after the accesskey bug was resolved. I'm looking into the bug again and will try relanding soon.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12f750a10326
https://hg.mozilla.org/integration/autoland/rev/175950c7983f
Replace button.footer with moz-button in browser/base/content/ r=places-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/e5d79af54c80
https://hg.mozilla.org/integration/autoland/rev/cbbb1bd02a4a
Replace button.footer with moz-button in browser/components/customizableui/ r=desktop-theme-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/bafa1af23562
https://hg.mozilla.org/integration/autoland/rev/097c8b9ac5ca
Replace button.footer with moz-button in browser/components/downloads/ r=akulyk
https://github.com/mozilla-firefox/firefox/commit/afa5169787e0
https://hg.mozilla.org/integration/autoland/rev/7bd60ae8cf94
Replace button.footer with moz-button in browser/components/remotecontrol/ r=akulyk,desktop-theme-reviewers
https://github.com/mozilla-firefox/firefox/commit/f5f03864b6bc
https://hg.mozilla.org/integration/autoland/rev/09ac2b043f79
Replace button.footer with moz-button in browser/components/reportbrokensite/ r=desktop-theme-reviewers,webcompat-reviewers,akulyk,twisniewski
https://github.com/mozilla-firefox/firefox/commit/d19513b12b2b
https://hg.mozilla.org/integration/autoland/rev/4da1dc7ec0f8
Replace button.footer with moz-button in browser/components/translations/ r=translations-reviewers,akulyk,desktop-theme-reviewers,nordzilla
https://github.com/mozilla-firefox/firefox/commit/27ff3068f606
https://hg.mozilla.org/integration/autoland/rev/aa7f931f24e2
Replace button.footer with moz-button in toolkit/content/widgets/ r=reusable-components-reviewers,omc-reviewers,akulyk,emcminn,media-playback-reviewers,urlbar-reviewers,nimbus-reviewers,jteow,padenot,sachung
https://github.com/mozilla-firefox/firefox/commit/d13b1ab8a543
https://hg.mozilla.org/integration/autoland/rev/009b8d0f92ca
Remove unused .footer-button CSS r=desktop-theme-reviewers,akulyk

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d5d1eeddb7e
https://hg.mozilla.org/integration/autoland/rev/31f86d797417
Revert "Bug 2005078 - Remove unused .footer-button CSS r=desktop-theme-reviewers,akulyk" for causing failures at browser_RemoteSettingsCrashPull_notification.js.

Comment 17

[Atila Butkovits]

Backed out for causing failures at browser_RemoteSettingsCrashPull_notification.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/31f86d797417

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=009b8d0f92ca4c69df7ef27b71ccc14aaac30171&selectedTaskRun=ISZ_Kd4XSTaB9_lqiNq-DA.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=606390183&repo=autoland&task=ISZ_Kd4XSTaB9_lqiNq-DA.0&lineNumber=14568
https://treeherder.mozilla.org/logviewer?job_id=606354443&repo=autoland&task=Piu3NZbmTQaTIoqJFLYTBg.0&lineNumber=22009

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e1dca9e03afd
https://hg.mozilla.org/integration/autoland/rev/bdbc5cf215f3
Replace button.footer with moz-button in browser/base/content/ r=places-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/3e25cf80e855
https://hg.mozilla.org/integration/autoland/rev/92769bde2d37
Replace button.footer with moz-button in browser/components/customizableui/ r=desktop-theme-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/8473ec210feb
https://hg.mozilla.org/integration/autoland/rev/8775860953c8
Replace button.footer with moz-button in browser/components/downloads/ r=akulyk
https://github.com/mozilla-firefox/firefox/commit/2e9fdb421425
https://hg.mozilla.org/integration/autoland/rev/32516a99a2a7
Replace button.footer with moz-button in browser/components/remotecontrol/ r=akulyk,desktop-theme-reviewers
https://github.com/mozilla-firefox/firefox/commit/7a6b47bb3745
https://hg.mozilla.org/integration/autoland/rev/e4f335032378
Replace button.footer with moz-button in browser/components/reportbrokensite/ r=desktop-theme-reviewers,webcompat-reviewers,akulyk,twisniewski
https://github.com/mozilla-firefox/firefox/commit/4d9bf6860d05
https://hg.mozilla.org/integration/autoland/rev/7c16252023b4
Replace button.footer with moz-button in browser/components/translations/ r=translations-reviewers,akulyk,desktop-theme-reviewers,nordzilla
https://github.com/mozilla-firefox/firefox/commit/1bfdbefcee4b
https://hg.mozilla.org/integration/autoland/rev/bc79db77afbf
Replace button.footer with moz-button in toolkit/content/widgets/ r=reusable-components-reviewers,omc-reviewers,akulyk,emcminn,media-playback-reviewers,urlbar-reviewers,nimbus-reviewers,jteow,padenot,sachung,webdriver-reviewers,whimboo
https://github.com/mozilla-firefox/firefox/commit/2284791a733a
https://hg.mozilla.org/integration/autoland/rev/382acb6e220a
Remove unused .footer-button CSS r=desktop-theme-reviewers,akulyk

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bdbc5cf215f3
https://hg.mozilla.org/mozilla-central/rev/92769bde2d37
https://hg.mozilla.org/mozilla-central/rev/8775860953c8
https://hg.mozilla.org/mozilla-central/rev/32516a99a2a7
https://hg.mozilla.org/mozilla-central/rev/e4f335032378
https://hg.mozilla.org/mozilla-central/rev/7c16252023b4
https://hg.mozilla.org/mozilla-central/rev/bc79db77afbf
https://hg.mozilla.org/mozilla-central/rev/382acb6e220a