Consider using moz-visual-picker for the visible/full page choice in the Screenshots panel
Categories
(Firefox :: Screenshots, enhancement)
Tracking
()
People
(Reporter: akulyk, Unassigned)
References
Details
(Keywords: access)
Attachments
(1 file)
|
13.01 KB,
image/png
|
Details |
The Screenshots panel offers two tiles, "Save visible" and "Save full page" (#visible-page and #full-page in screenshots-buttons.js). Visually they work as a choice between two capture modes, but they're built as custom buttons.
Some problems with the current design:
- The labels say "Save", but pressing one doesn't save anything. It opens the preview dialog, where the actual Download and Copy actions are.
- The tiles look like a visual picker, but they behave as instant actions: choosing one closes the panel straight away.
Proposal: use moz-visual-picker for the choice between "Visible" and "Full page", and add a separate action button to continue (e.g. "Take screenshot"; wording to be confirmed by content design) or a moz-visual-picker type="listbox" (in listbox mode, arrow keys only move focus between options, and the screenshot starts when an option is activated with Enter, Space or a click) with no additional button needed. The picker should get a proper visible title through its label (e.g. "Choose what to capture"). That gives the group an accessible name, so screen readers announce what the options are for.
The Mini Window chooser in the same panel ("Move selection" / "Move full tab") uses the same tile pattern, and has the same open question. Ideally both use the same component. See bug 2075913.
Comment 1•1 month ago
|
||
The Bugbug bot thinks this bug is an accessibility bug, but please revert this change in case of error.
Description
•