Closed Bug 2005730 Opened 8 months ago Closed 8 months ago

Searching Settings for "card" doesn't find the credit card / payment settings

Categories

(Firefox :: Settings UI, defect)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
148 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox146 --- wontfix
firefox147 --- wontfix
firefox148 --- verified
firefox149 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Searching Settings for "card" (or "debit" or "credit") doesn't find the credit card / payment settings.

This is a bit of a papercut for people trying to find their credit/debit cards in settings. It used to work.

If the design is such we don't want to show text that includes these words, I believe the find in page implementation does also support providing additional strings that will find the relevant setting (which we at least used to use for e.g. primary password so that the old "master" terminology could still find it).

:mtigley, since you are the author of the regressor, bug 1971626, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(mtigley)

It looks like we just missed moving search-l10n-ids over to the config-based settings. There are a few examples of how this can be done - here's one. Restoring those should fix this issue.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://github.com/mozilla-firefox/firefox/commit/b6455e4c30a8 https://hg.mozilla.org/integration/autoland/rev/46ebceab2275 make 'card' find payments by restoring search-l10n-ids in settings, r=credential-management-reviewers,mtigley
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
Severity: -- → S4
Flags: needinfo?(mtigley)

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(gijskruitbosch+bugs)

I tried to request uplift but this requires manual rebase which seems not worth it.

Flags: needinfo?(gijskruitbosch+bugs)
Blocks: 2008221
QA Whiteboard: [qa-triage-done-c149/b148] [qa-ver-needed-c149/b148]
Flags: qe-verify+
QA Contact: ailea

Verified - Fixed in Nightly 148.0a1(2025-12-20) and Nightly 149.0a1 (2026-01-13). Searching for "card" in about:preferences page, will find the Payment methods section as expected.

Status: RESOLVED → VERIFIED
Has STR: --- → yes
QA Whiteboard: [qa-triage-done-c149/b148] [qa-ver-needed-c149/b148] → [qa-triage-done-c149/b148] [qa-ver-done-c149/b148]
Flags: qe-verify+
Duplicate of this bug: 1998367
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: