2008221 - Firefox preferences has no search results for "credit" or "card"

Status: VERIFIED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STR:

1. (optional) Save a credit card as a payment method in Firefox.
2. Visit Firefox preferences (about:preferences)
3. Click the search box and type in "credit" and/or "card".

EXPECTED RESULTS:
Should see the "Payment methods" UI.

ACTUAL RESULTS:
No results:
Sorry! There are no results in Settings for “credit”.
Sorry! There are no results in Settings for “card”.

If you search for "Payment" instead, then Firefox does show the correct section of preferences. That section happens not to mention "Credit" at all, though it does have "Cards" as header-text in a modal popup when you click "Manage payment methods".

Right now we're doing a simple find-in-the-top-level-preferences-content for the search terms. I wonder if we have some way of adding additional hidden "hint" terms in e.g. hidden elements within a section? (e.g. maybe we could have a hidden div in the "Payment methods" section that has the phrase "credit cards", which exists solely to ensure that that section comes up as a match when a user searches preferences for it)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing no search results for "credit"

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing no search results for "card"

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot showing that we do in fact show the word "cards" in the payment methods modal-popup (near bottom right of screenshot)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2008221 - Make the payment methods settings easier to find by adding additional search term matches. r?#settings-reviewers!

Comment 5

[:Gijs (he/him)]

I added "card" back in bug 2005730.

Comment 6

[Daniel Holbert [:dholbert]]

"credit" (or "credit card") would still be handy. I just tripped over this again today.

It is nice that "card" works now, but I suspect folks are more likely to search for this by typing either "credit" or "credit card" (which currently give no results).

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Here's the list of additional terms that content design suggests:

• cards
• credit
• debit
• wallet
• checkout

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b824fc54507c
https://hg.mozilla.org/integration/autoland/rev/e6ef2bf12918
Make the payment methods settings easier to find by adding additional search term matches. r=fluent-reviewers,credential-management-reviewers,Gijs,mtigley,bolsson

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e6ef2bf12918

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Nightly 149.0a1(build id: 20260129094811). The payment methods section can be now found by searching for any term listed in comment 7.