2005852 - Spam folder context menu has duplicate accelerator keys (S)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P3)

Description

[Ed]

Attachment: spam folder.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:146.0) Gecko/20100101 Firefox/146.0

Steps to reproduce:

R. clicked the Spam folder to show the context menu and pressed the 'S' key

Actual results:

'Search' was selected but search didn't open.

Expected results:

Search should have opened.

'S' is also the accelerator keys for 'Empty spam'. Pressing 'S' just rotates between the two options and doesn't trigger either of them.

Comment 1

[Anje]

in Daily 148.0a1
Repeatedly using keyboard 'S' moves between the two options thus allowing user to focus on an option as described by Ed.
When selected/highlighted prefered option - the new additional action required is to press 'Enter'/'Return' key.

So the change from 'Junk' to 'Spam' has meant additional action on the part of the user to invoke the chosen option.

Previously:
only 'Search Messages' used 'S' and pressing 'S' auto opened search.
only 'Empty Junk' used 'J' and pressing 'J' auto popped up warning to ask if you really wanted to empty junk.

Comment 2

[Alessandro Castellani [:aleca]]

Thanks for the report.
As Anje correctly stated, having the same access key is not inherently a bad or incorrect thing, since hitting the same key will cycle through all those items that have that character.
Nonetheless, I think we can easily fix it for en-* locales by using the E accesskey.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 2005852 - Change accesskey for the Empty Spam English menuitem. r=#thunderbird-reviewers

Right click on a Spam folder to see the menuitem.
This should remove any duplicate accesskey from that menu.
It shouldn't require a new Fluent ID since it's a en-US only change
and localizers could/will have a different accesskey.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fea2de029ba4
Change accesskey for the Empty Spam English menuitem. r=tobyp