2006158 - Ensure release-level takes Github branches into account

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

Currently the "release-level" is simply determined by whether a project is listed in RELEASE_PROJECTS or not. This works fine for hgmo based projects, but on Github we'll typically have a single project (aka repo), where some specific branches handle releases, and others don't.

The existing model will fail as it's all or nothing. We need to take into account the Git branch as well.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2006158 - Use 'release_level' utility function when resolving "release" run-on-projects alias, r?#releng-reviewers

There should be only a single implementation that determines whether a project
is release or not.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2006158 - Pass full set of params into gecko_taskgraph.util.attributes.release_level, r?#releng-reviewers

This will allow us to determine release_level at a more granular level
in the next commit.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2006158 - Factor in Git branch ref when determining release_level, r?#releng-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/565bb775ad8c
https://hg.mozilla.org/integration/autoland/rev/99b2cf798d4c
Use 'release_level' utility function when resolving "release" run-on-projects alias, r=releng-reviewers,taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/92624c897d50
https://hg.mozilla.org/integration/autoland/rev/4ec032cd681a
Pass full set of params into gecko_taskgraph.util.attributes.release_level, r=releng-reviewers,taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/17c5069730fe
https://hg.mozilla.org/integration/autoland/rev/244464f6694b
Factor in Git branch ref when determining release_level, r=releng-reviewers,taskgraph-reviewers,jcristau

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f4356205c44b
https://hg.mozilla.org/integration/autoland/rev/4bfcebf5af24
Revert "Bug 2006158 - Factor in Git branch ref when determining release_level, r=releng-reviewers,taskgraph-reviewers,jcristau" for causing failures complaining about TypeError.

Comment 6

[Atila Butkovits]

Backed out for causing failures complaining about TypeError.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/4bfcebf5af24562ad6223f7f40cc7db49490856e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=244464f6694b7f503df65ae90c09a0b1ce966d41&selectedTaskRun=AepSvhbZRHK7K6VKQeycnw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=540732242&repo=autoland&task=AepSvhbZRHK7K6VKQeycnw.0&lineNumber=304

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ba8bd1b9b0d
https://hg.mozilla.org/integration/autoland/rev/83673cf6c4d0
Use 'release_level' utility function when resolving "release" run-on-projects alias, r=releng-reviewers,taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/1bde3c9d3e5b
https://hg.mozilla.org/integration/autoland/rev/c80484e9c24d
Pass full set of params into gecko_taskgraph.util.attributes.release_level, r=releng-reviewers,taskgraph-reviewers,jcristau
https://github.com/mozilla-firefox/firefox/commit/5129ce03b505
https://hg.mozilla.org/integration/autoland/rev/9a8eaf1773a4
Factor in Git branch ref when determining release_level, r=releng-reviewers,taskgraph-reviewers,jcristau

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/83673cf6c4d0
https://hg.mozilla.org/mozilla-central/rev/c80484e9c24d
https://hg.mozilla.org/mozilla-central/rev/9a8eaf1773a4

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/83673cf6c4d0
https://hg.mozilla.org/mozilla-central/rev/c80484e9c24d
https://hg.mozilla.org/mozilla-central/rev/9a8eaf1773a4