2006549 - Restrict localised folder names to those with specific names

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, task, P1)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 2006549 - Restrict localised folder names to those with specific names. r=aleca!,edicharry!

This takes us back to an earlier version¹ but with the addition of a few more names.

¹ https://hg-edge.mozilla.org/comm-central/diff/0c02f4237c83098e84a3424f95bd8d6a55517226/mailnews/base/src/nsMsgDBFolder.cpp#l1.190

Comment 2

[Geoff Lankow (:darktrojan)]

For context, we're evaluating our options on this. I've put this patch up because it is one of the options and is ready for review, if we decide to go this way.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c781e8dd8528
Restrict localised folder names to those with specific names. r=aleca,edicharry

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9533566 [details]
Bug 2006549 - Restrict localised folder names to those with specific names. r=aleca!,edicharry!

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: We want this to reach the release channel so that we don't have to back out the previous version again.
• User impact if declined: Users of non-English locales will continue to see folders with English names (current state of release), or all folders with special flags will have translated names (current state of beta). Neither of these is really acceptable.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Technically this is just a runtime decision about whether a folder is displayed with a localised name or not. There's no changes to data or anything else that is permanent.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 5

[Corey Bryant]

Comment on attachment 9533566 [details]
Bug 2006549 - Restrict localised folder names to those with specific names. r=aleca!,edicharry!

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Comment on attachment 9533566 [details]
Bug 2006549 - Restrict localised folder names to those with specific names. r=aleca!,edicharry!

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: We want this to reach the release channel so that we don't have to back out the previous version again.
• User impact if declined: Users of non-English locales will continue to see folders with English names (current state of release), or all folders with special flags will have translated names (current state of beta). Neither of these is really acceptable.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Technically this is just a runtime decision about whether a folder is displayed with a localised name or not. There's no changes to data or anything else that is permanent.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed:

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 147.0:
https://hg.mozilla.org/releases/comm-release/rev/06a73e47bd62