Open Bug 2006623 Opened 12 days ago Updated 12 hours ago

Remove "browser.urlbar.switchTabs.searchAllContainers" pref

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task

Tracking

()

People

(Reporter: mak, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

This pref is adding significant maintanance costs, from our telemetry measurements it has been barely used, less then 0.01% of users set it to false.
We feel like the default functionality is pretty good, and if there's the need to search specific containers, I think we should implement it in the unified search button (things like searching specific container, specific group, specific device...) as a search mode.

Hey Marco, I just landed Bug 2005392 which removes the pref as well. I think we can resolve this bug as fixed as well.

The patch removes the telemetry probe, not the pref and the code using it. https://searchfox.org/firefox-main/search?q=switchTabs.searchAllContainers

Flags: needinfo?(dong)

This pref is adding significant maintanance costs, from our telemetry measurements it has been barely used, less then 0.01% of users set it to false.

Just a FYI, it was never exposed in the UI which could explain it. See bug 1882391 (which funnily I just rediscovered we were both involved in).

I think we should implement it in the unified search button (things like searching specific container, specific group, specific device...) as a search mode.

Good point. :mak do you mind filing a bug report blocking bug 1191418 so it's documented.

Flags: needinfo?(mak)
Blocks: 2007881

(In reply to Danny Colin [:sdk] from comment #3)

Just a FYI, it was never exposed in the UI which could explain it. See bug 1882391 (which funnily I just rediscovered we were both involved in).

Yep, as I said there we'd have to take a decision, and based on most current discussions, the decision is to wontfix that and remove the pref (for now). I agree that not showing a pref will reduce its use, but it was not shown exactly because we already doubted about the approach.

I think we should implement it in the unified search button (things like searching specific container, specific group, specific device...) as a search mode.

Good point. :mak do you mind filing a bug report blocking bug 1191418 so it's documented.

Sure, I filed bug 2007881.

Flags: needinfo?(mak)
You need to log in before you can comment on or make changes to this bug.