Closed Bug 2006822 Opened 5 months ago Closed 3 months ago

[Regression] Since version 135.0 DevTools Network tab doesn't log requests if URL prefixed with view-source:

Categories

(DevTools :: Netmonitor, defect, P2)

Firefox 146
Desktop
Windows 11
defect

Tracking

(firefox-esr115 unaffected, firefox-esr140 wontfix, firefox146 wontfix, firefox147 wontfix, firefox148 wontfix, firefox149 fixed)

RESOLVED FIXED
149 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- wontfix
firefox146 --- wontfix
firefox147 --- wontfix
firefox148 --- wontfix
firefox149 --- fixed

People

(Reporter: a.broughton.en, Assigned: bomsy)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:146.0) Gecko/20100101 Firefox/146.0

Steps to reproduce:

  1. Open firefox to new tab
  2. Open DevTools (F12 or Right-Click Inspect in page or CTRL+SHIFT+I)
  3. Select Network tab
  4. Select Settings cog on right side and ensure Persist Logs is selected
  5. Visit URL: view-source:https://bugzilla.mozilla.org

Regression in version 135.0, version 134.0.2 and before correctly log the requests in the network tab

Version Status
134.0.2 (64-bit) Shows network request - OK
135.0 (64-bit) Network request now shown - !OK

Nightly 148.0a1 (20251217214341) tested, also faces regression.

This was discovered while tracking redirects from a malicious link, it redirected through three different domains and not a single requests was logged if the URL was prefixed with view-source:. Versions prior to 135.0 worked as intended / expected.

Actual results:

No requests listed in Network tab

Expected results:

Request should have been logged

Component: Untriaged → Netmonitor
OS: Unspecified → Windows 11
Product: Firefox → DevTools
Hardware: Unspecified → Desktop

Type in table: 135.0 Status should show not shown, instead of now shown.

Version Status
134.0.2 (64-bit) Shows network request - OK
135.0 (64-bit) Network request not shown - !OK

Thanks for filing. Interesting. I wonder if this was affected by Bug 1932818

Flags: needinfo?(hmanilla)

Is the needinfo and regressionwindow-wanted requesting information from me? Regression is since version 135.0. What other info is required?

(In reply to a.broughton.en from comment #3)

Is the needinfo and regressionwindow-wanted requesting information from me? Regression is since version 135.0. What other info is required?

the needinfo is for bomsy to look at, and the other flag was to run mozregression (https://mozilla.github.io/mozregression/) to get a shorter regression window, but that wasn't for you to do, you're all good :)


I was only able to get this pushlog https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=b6fe6098a8bbf74edca23103c6756be13d238378&tochange=c9170b504cdce7fd51d1934bad32709bea49b112 , which is a bit large, but does include Bug 972821 and Bug 1932818 , which could impact this

Hi a.broughton.en,
Just got back from holiday, yes it was as Nicholas said, the need-info was for me.

Thanks Nicholas for the regression window to confirm, i'll take a look to fix

P2 since it's a regression and bomsy already started investigating the issue.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Priority: -- → P2
Regressed by: 1932818

Set release status flags based on info from the regressing bug 1932818

Flags: needinfo?(hmanilla)
Assignee: nobody → hmanilla
Attachment #9536900 - Attachment description: WIP: Bug 2006822 - [devtools] Show the base request for a view-source page → Bug 2006822 - [devtools] Show the base request for a view-source page r=#devtools
Status: NEW → ASSIGNED

Hubert, are you going to land this patch before the merge?

Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0e6139ac87b1 https://hg.mozilla.org/integration/autoland/rev/575a4544bc23 [devtools] Show the base request for a view-source page r=devtools-reviewers,jdescottes

Hubert, are you going to land this patch before the merge?

Landed! Thanks for the reminder.

Flags: needinfo?(hmanilla)
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7c71376b2312 https://hg.mozilla.org/integration/autoland/rev/a1794c898e48 Revert "Bug 2006822 - [devtools] Show the base request for a view-source page r=devtools-reviewers,jdescottes" for causing devtools failures in browser_resources_network_event_stacktraces_keepalive.js.

Reverted this because it was causing devtools failures in browser_resources_network_event_stacktraces_keepalive.js.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | devtools/shared/commands/resource/tests/browser_resources_network_event_stacktraces_keepalive.js | Stack trace for keepalive request was received

Please also check these failures.

Flags: needinfo?(hmanilla)

Thanks, i've fixed the issue and just pushed. to auto land.

Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8b2087be98dd https://hg.mozilla.org/integration/autoland/rev/1d5839bcbbaf [devtools] Show the base request for a view-source page r=devtools-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

I look forward to the release.
Thank you for your work on this! :)

QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: