2007171 - The unified toolbar size is inconsistent between tabs

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Alex Franchuk [:afranchuk]]

When clicking between tabs, the size of the top frame of the window chrome changes (it is a few pixels shorter for the calendar and tasks tabs). This is likely due to the frame sizing based on the content: the mail, address book, and chat tabs have a search box there, whereas the calendar and tasks tabs have buttons to synchronize, add tasks, etc.

Comment 1

[Alex Franchuk [:afranchuk]]

It's come to my attention that the toolbar is configurable, and that the current default doesn't exhibit this behavior (having only a search bar for each tool). At some point the default must have, though, because I never configured these layouts myself. Still, it may be worth making the search bar minimum vertical height slightly smaller so that it matches the minimum height of the buttons (so if someone has a toolbar without the search bar, it won't exhibit this difference in height).

Comment 2

[Richard Marti (:Paenglab)]

The issue is, that the unified toolbar height isn't the same with and without buttons.

A solution could be to set a min-height on the toolbar but this different values depending on the used button style (Icons beside text, Icons above text etc.).

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 2007171 - Set the unified toolbar height font size and button mode dependent. r=#thunderbird-front-end-reviewers

Comment 4

[Martin Giger [:freaktechnik]]

(In reply to Alex Franchuk [:afranchuk] from comment #1)

At some point the default must have, though, because I never configured these layouts myself.

Just to complete this story, since I wasn't around anymore to answer this on Matrix before the holidays:
We migrated existing toolbar contents, so profiles that existed before the unified toolbar also get the contents they had in the mail, calendar etc. toolbars in the unified toolbar. However, new profiles don't get anything apart from the global search in the toolbar, since we're providing interaction points in the relevant context for the actions that were previously put into the toolbars.

At the time we didn't quite have the tools to reliably know the required height for the toolbar with all the available variables (density, font size, toolbar button style and contents) and we didn't want to arbitrarily restrict the height. However our code base has improved and I'm pleased to see Richard seems to have found a fairly nice way to handle the variations now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/33b50dff32b2
Set the unified toolbar height font size and button mode dependent. r=freaktechnik