2007183 - Hide sidebar launcher on panel close if it was hidden prior to panel open

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Ania]

As a user who prefers to keep the sidebar in the hidden state (no launcher visible on the screen), if the sidebar launcher is hidden at the moment I open a sidebar panel via a keyboard shortcut or from the Application menu > View > Sidebar, I want the launcher to go back to the hidden state when I close the panel in either of these ways:

• via a keyboard shortcut,
• by clicking the X button within the sidebar panel,
• by going to Application menu > View > Sidebar and unchecking the panel I have open.

Sample STRs:

• Make sure the sidebar is in the hidden state.
• Open the history (Ctrl + H) or bookmarks (Ctrl + B) panel via a shortcut.
• Close the history panel or bookmarks via X button.

Expected result
The panel is closed, and the launcher is hidden.

Actual result as of Firefox 146/December 2025
The panel is closed, and the launcher remains visible.

Comment 3

[gabriele]

The same problem occurs with vertical tabs: I have classic tabs with the sidebar disabled. I enabled vertical tabs and then disabled them. The sidebar was automatically enabled.

Comment 5

[Sam Foster [:sfoster] (he/him)]

I can take a look at this one.

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to Ania from comment #0)

Expected result
The panel is closed, and the launcher is hidden.

What about the case where sidebar.visibility=="hide-sidebar", but the sidebar launcher had been toggled to visible before opening the bookmark panel? Would we expect the launcher to remain visible when closing the panel in that case (which implies a kind of stack of states?)

Comment 7

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 2007183 - Restore sidebar launcher as shown/hidden when closing a sidebar panel. r?#sidebar-reviewers

• When the visibility pref is hide-sidebar, we should always return the launcher to its previous hidden-ness after a sidebar panel is closed
• New test coverage for these scenarios

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33d090e11a41
https://hg.mozilla.org/integration/autoland/rev/ba48f4190cde
Restore sidebar launcher as shown/hidden when closing a sidebar panel. r=nsharpley

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4760831e3beb
https://hg.mozilla.org/integration/autoland/rev/577c0db51b49
Revert "Bug 2007183 - Restore sidebar launcher as shown/hidden when closing a sidebar panel. r=nsharpley" for causing bc faiulres @browser_ext_sidebarAction.js.

Comment 10

[agoloman]

Backed out for causing bc faiulres @browser_ext_sidebarAction.js.

• Backout link
• Push with failures
• Failure Log

Comment 11

[Sam Foster [:sfoster] (he/him)]

(In reply to agoloman from comment #10)

Backed out for causing bc faiulres @browser_ext_sidebarAction.js.

Thanks. Fixed, reviewed and re-queued for landing.

Comment 12

[Sam Foster [:sfoster] (he/him)]

Clearing need-info for asafko. This was quite simple: we note the visibility (hidden-ness) of the launcher when opening a panel, and when closing a panel, as long as the sidebar.visibility is hide-sidebar, we set the launcher back to the state it was in before opening the panel.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61753985429b
https://hg.mozilla.org/integration/autoland/rev/bdbc26bfbefe
Restore sidebar launcher as shown/hidden when closing a sidebar panel. r=nsharpley,extension-reviewers,robwu

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bdbc26bfbefe