Open Bug 1977232 (sidebar-parity) Opened 1 year ago Updated 26 days ago

[meta] Sidebar: functional improvements and old version parity

Categories

(Firefox :: Sidebar, task)

task

Tracking

()

a11y-review changes required

People

(Reporter: asafko, Unassigned)

References

(Depends on 13 open bugs)

Details

(Keywords: meta)

To ease the burden of maintaining two versions of the same surface and reduce experience fragmentation, this metabug will gather the work necessary to:

  • Ensure the comparable level of experience for existing users of the old sidebar, with the caveat that UX of the two surfaces is not identical and we are not pursuing 1:1 identic experience.
  • Deprecate the old sidebar (sidebar.revamp = false) and transition current users to the new version.
  • Enable the new sidebar (sidebar.revamp = true) by default.
Depends on: 1972168, 1973189, 1962251
Keywords: meta
Depends on: 1978102
Depends on: 1984749
Blocks: 2006544
Depends on: 1910103
Summary: [meta] Deprecate the old sidebar by the end of 2025 → [meta] Old sidebar deprecation
Depends on: 2005743
Depends on: 1975394
Depends on: 2007183
Depends on: 2009396
Depends on: 2009398
Depends on: 2009401
Depends on: 2009402
Depends on: 2011000
No longer blocks: 2006544
Depends on: 1927457
Depends on: 2019901
No longer depends on: 2009401
See Also: → 2009401
Depends on: 2043899
Depends on: 2044804
Depends on: 2044805

Description:
Please provide an explanation of the feature or change. Include a description of the user scenario in which it would be used and how the user would complete the task(s).
Screenshots and visual UI specs are welcome, but please include sufficient accompanying explanation so that blind members of the accessibility team are able to understand the feature/change.
The new sidebar that has been enabled by default in Nightly for a while (sidebar.revamp pref must be true). We've added a lot since the original implementation and a11y review (see https://bugzilla.mozilla.org/show_bug.cgi?id=1879923#c1) and we need to enable this by default before 155 for all old sidebar users.

How do we test this?
If there is an implementation to test, please provide instructions for testing it; e.g. setting preferences, other preparation, how to trigger the UI, etc.
Please ensure sidebar.revamp is true if you've otherwise changed it in Nightly, and also that browser.nova.enabled is set to true to reflect the changes we've made for the nova redesign. Additionally, the new replacement bookmarks panel sidebar.updatedBookmarks.enabled; it uses the same base list as the other sidebar panels we own (history and synced tabs) but with additional functionality to bring it up to parity with the old bookmarks panel.

When will this ship? Was slated for 153 but we'll likely push this to 154. It needs to ship by 155 (nova release) since the new sidebar design is part of the changes and we want to ship it before then.
Tracking bug/issue: This bug
Design documents (e.g. Product Requirements Document, UI spec): figma spec is here.
Engineering lead: Sarah Clements
Product manager: Ania Safko

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:

Describe any areas of concern to which you want the accessibility team to give special attention: I want to note that we recently made the splitter accessible for splitview see bug 2012633, which never was given keyboard support previously, and there's still likely work to do there. Please focus on the interactions with horizontal and vertical tabs and the different settings with the sidebar and sidebar panels, particularly keyboard navigation.

See Also: → 1879923
Depends on: 2043614

Refer to the comment #2 above

a11y-review: --- → requested
Depends on: 2046673
Depends on: 2046675
Depends on: 2046678
Depends on: 2049930
Depends on: 2049931
Depends on: 2049932
Depends on: 2051182
Depends on: 2051183
Depends on: 2053229
Depends on: 2053230
Depends on: 2053232
Depends on: 2053234
Depends on: 2053235
Depends on: 2053236
Depends on: 2053237
Depends on: 2053238
Depends on: 2053242
No longer depends on: 2053230
No longer depends on: 2053236
No longer depends on: 2053237
No longer depends on: 2053232
a11y-review: requested → changes required

Per our triage guidelines, there are no current accessibility s2s that would outright block shipping. Thanks for addressing those. That said, there are some high s3s that are significant regressions from the existing sidebar and which may exasperate users, especially since we're enabling the new sidebar by default and eventually removing the ability to disable the old one: bug 2046673, bug 2051182, bug 2051183. Thus, I'm marking this as "changes required" rather than "passed", as these should be addressed as soon as possible even if they don't make the first ship release.

Depends on: 2070260
No longer depends on: 2053235
Summary: [meta] Old sidebar deprecation → [meta] New sidebar parity / old sidebar deprecation

The dropdown panel selector for the new sidebar is very heavily bugged (tested on Firefox 156.0.1). I cannot navigate away from the Bookmarks tab/tool using the mouse to navigate. And because I have not selected an AI chatbot of my choice yet, the dropdown panel selector is also bugged for the AI Chatbot tab, I cannot navigate away from that tab/tool using the mouse. I have filed Bug 2076296 for this.

https://connect.mozilla.org/t5/discussions/phasing-out-the-older-version-of-firefox-sidebar-in-2026/td-p/115477/page/2
Citation from asafko:
With Nova coming out in 157 and as we have not been supporting and testing the old sidebar for a while, we will be turning the updated sidebar on for tWith Firefox 157. If you were on the old version of the sidebar, your layout will default to the dropdown selector, as in the old version.

Defaulting to the dropdown selector for the people still using the old version of the sidebar is an absolutely terrible idea! A very large amount of people is going to be using the dropdown selector then, and it is heavily bugged! So if it is still possible to change this before the release of Firefox 157, then you have to respond immediately! Is it still possible to prevent the dropdown panel selector from getting enabled by default for the people who were using the old sidebar? This is going to happen very soon, when Firefox 157 launches. But because the dropdown panel selector is very heavily bugged, this should be prevented by all means. Unchecking the option Open tools from sidebar causes the navigation through the various tabs/tools with the mouse to become bugged, and so the option Open tools from sidebar should be ENABLED BY DEFAULT FOR EVERY SINGLE FIREFOX USER!

(In reply to dusty-2011 from comment #5)

The dropdown panel selector for the new sidebar is very heavily bugged (tested on Firefox 156.0.1). I cannot navigate away from the Bookmarks tab/tool using the mouse to navigate. And because I have not selected an AI chatbot of my choice yet, the dropdown panel selector is also bugged for the AI Chatbot tab, I cannot navigate away from that tab/tool using the mouse. I have filed Bug 2076296 for this.

https://connect.mozilla.org/t5/discussions/phasing-out-the-older-version-of-firefox-sidebar-in-2026/td-p/115477/page/2
Citation from asafko:
With Nova coming out in 157 and as we have not been supporting and testing the old sidebar for a while, we will be turning the updated sidebar on for tWith Firefox 157. If you were on the old version of the sidebar, your layout will default to the dropdown selector, as in the old version.

Defaulting to the dropdown selector for the people still using the old version of the sidebar is an absolutely terrible idea! A very large amount of people is going to be using the dropdown selector then, and it is heavily bugged! So if it is still possible to change this before the release of Firefox 157, then you have to respond immediately! Is it still possible to prevent the dropdown panel selector from getting enabled by default for the people who were using the old sidebar? This is going to happen very soon, when Firefox 157 launches. But because the dropdown panel selector is very heavily bugged, this should be prevented by all means. Unchecking the option Open tools from sidebar causes the navigation through the various tabs/tools with the mouse to become bugged, and so the option Open tools from sidebar should be ENABLED BY DEFAULT FOR EVERY SINGLE FIREFOX USER!

Hi,
Really appreciate you catching the issue. Unfortunately, there is nothing we can do to change the migration that already happened with the settings mentioned above. The ticket with the fix is currently targeting the upcoming dot release – this is the quickest timeline for us to deliver a fix.

Depends on: 2078235
Depends on: 2080879
Summary: [meta] New sidebar parity / old sidebar deprecation → [meta] Sidebar: functional improvements and old version parity
Depends on: 2069488
Depends on: 2041947
Depends on: 1964909
Depends on: 2077272
Alias: sidebar-parity
Depends on: 2084201
You need to log in before you can comment on or make changes to this bug.