2007316 - `mach try` commands return job_id as exit code instead of 0 on success

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Logan Rosen [:Logan]]

./mach try auto and other try commands return a non-zero exit code (the Lando job_id, e.g., 48) even when the push succeeds. This breaks shell scripting conventions where 0 indicates success and non-zero indicates failure.

Steps to Reproduce:

./mach try auto
echo $?

Expected Result:
Exit code 0 (success)

Actual Result:
Exit code 48 (or other job_id number)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1964784

:sparky, since you are the author of the regressor, bug 1964784, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Logan Rosen [:Logan]]

Attachment: Bug 2007316 - Fix mach try commands returning job_id as exit code instead of 0 r?sparky

./mach try commands were returning the Lando job_id (e.g., 48) as the shell
exit code instead of 0 on success. This broke shell scripting conventions.

The issue was introduced in Bug 1964784 when push_to_try() was changed to
return the job_id. This value propagated up through the mach command layer.

This fix normalizes exit codes in mach_commands.py to return 0 for success
while preserving error code 1 for validation failures.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:marco, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9e72050e08ea
https://hg.mozilla.org/integration/autoland/rev/57cf4a18dddc
Fix mach try commands returning job_id as exit code instead of 0 r=sparky

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/57cf4a18dddc