Closed Bug 2007530 Opened 11 months ago Closed 10 months ago

Space key should open the Manage Topics and Wallpaper panels

Categories

(Firefox :: Settings UI, defect)

Desktop
All
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox148 --- affected

People

(Reporter: Gabi, Unassigned)

References

(Blocks 1 open bug)

Details

Affected versions

  • Nightly 148.0a1

Affected platforms

  • Windows 11 x64, macOS 14, Ubuntu

Prerequisites
Enable the "Manage Topics" section:
browser.newtabpage.activity-stream.discoverystream.sections.enabled
browser.newtabpage.activity-stream.discoverystream.topicLabels.enabled
browser.newtabpage.activity-stream.discoverystream.sections.personalization.enabled
browser.newtabpage.activity-stream.discoverystream.sections.customizeMenuPanel.enabled
browser.newtabpage.activity-stream.feeds.section.topstories
browser.settings-redesign.enabled to true

Steps to reproduce

  1. Open about:preferences#home
  2. Using Tab key navigate to Manage Topics and Choose a wallpaper
  3. Hit Space key to open the new tab page

Expected result

  • HNT customization panel opens with Space key

Actual result

  • HNT customization panel does not open with Space key

Regression range

  • New feature

Those two options in the settings are actually links that lead outside the settings pages, that's the reason we're using the Box Link component: https://firefoxux.github.io/firefox-desktop-components/?path=/docs/ui-widgets-box-link-readme--docs

According to web a11y guidelines, anchor tags/links only open when pressing the "Enter" key, and not the "Space" key.

Resources:

  1. MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a

If the href attribute is present, pressing the enter key while focused on the <a> element will activate it.

  1. The A11y Collective: https://www.a11y-collective.com/blog/button-vs-link/

Links activate with the Enter key only, while buttons must respond to both Space and Enter.

So I think this issue is fine to close as it this behaviour does not need to be fixed. I'll mark this as "invalid" as it's the behaviour works as expected. Thanks for filing, though!

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.