Dialog lacks accessible name (Story topic sections > ••• disclosure > Block dialog)
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
| Accessibility Severity | s3 |
People
(Reporter: john.northup, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
(Keywords: access, good-first-bug)
Attachments
(2 files, 1 external file)
Steps to Reproduce
Open DevTools. In any Story topic section (e.g., Popular Today), activate the ••• button. Within the resulting disclosure, activate the Block button. Using the Accessibility Inspector, inspect the resulting dialog.
Expected Behavior
name describes the dialog.
Actual Behavior
name is undefined.
User Impact
User may not be fully aware of context.
WCAG 2.2 References
Recommendations
Apply aria-label="confirmation" to the dialog container.
Testing Environment
Any
Assistive Technology Used
Any
Code Pointers
<div class="confirmation-dialog">
<div class="modal-overlay" role="presentation"></div>
<div class="modal">
<section class="modal-message">
<span>
<p data-l10n-id="newtab-section-confirm-block-topic-p1">Are you sure you want to block this topic?</p>
<p data-l10n-id="newtab-section-confirm-block-topic-p2">Blocked topics will no longer appear in your feed.</p>
</span>
</section>
<section class="actions">
<button data-l10n-id="newtab-section-cancel-button">Not now</button>
<button class="done" data-l10n-id="newtab-section-block-topic-button" data-l10n-args="{"topic":"Popular Today"}">Block Popular Today</button>
</section>
</div>
</div>
Further Reference
| Reporter | ||
Comment 1•10 months ago
|
||
Updated•10 months ago
|
Comment 2•9 months ago
|
||
The issue can be seen as described by the reporter in Nightly 149.0a1. Marking as NEW.
Comment 3•9 months ago
|
||
Issue is similar to the bug 2008178
Comment 4•9 months ago
|
||
Assigning the Severity value to align with the Accessibility severity, per discussions with :thecount and :marco
Updated•9 months ago
|
Comment 5•8 months ago
|
||
Hello i am an outreachy intern can this be assigned to me
(In reply to Okhuomon Ajayi from comment #5)
Hello i am an outreachy intern can this be assigned to me
Hi Okhuomon, just a heads up! This 'Block' dialog uses the same component as the one in Bug 2008178. Since I have already submitted the patch for Bug 2008178 this bug will be fixed by that patch too. Just wanted to let you know so you don't spend time on it!
Comment 7•8 months ago
|
||
(In reply to Sameeksha from comment #6)
(In reply to Okhuomon Ajayi from comment #5)
Hello i am an outreachy intern can this be assigned to me
Hi Okhuomon, just a heads up! This 'Block' dialog uses the same component as the one in Bug 2008178. Since I have already submitted the patch for Bug 2008178 this bug will be fixed by that patch too. Just wanted to let you know so you don't spend time on it!
Ohh Alright
Updated•5 months ago
|
can you take a look into my patch and potentially land it thank you.
Comment 11•5 months ago
|
||
Is this bug essentially the same as bug 2008178, which was adding aria-labelledby, which this bug's filing pre dates the aria-labelledby patch?
Comment 12•5 months ago
|
||
No, they are not the same thing. Although, they are in the same area / component.
Comment 13•5 months ago
|
||
Testing this locally, it looks like the aria-labelledby is taking priority for me, and the value in aria-label is ignored? I'm using firefox devtools to text this, and I dunno if that's a complete test.
Comment 14•5 months ago
|
||
Since aria-labelledby takes priority over aria-label, should we remove aria-labelledby when dialog_label is provided, or is there a different approach you'd recommend?
Comment 15•5 months ago
|
||
I'm not sure if that's a question for me or not, but having both does feel weird.
Scrolling up in this bug, I see this comment:
Hi Okhuomon, just a heads up! This 'Block' dialog uses the same component as the one in Bug 2008178. Since I have already submitted the patch for Bug 2008178 this bug will be fixed by that patch too. Just wanted to let you know so you don't spend time on it!
It does sound like there is evidence to suggest this bug can be resolved with the fix there, with the aria-labelledby? That would be ideal.
No, they are not the same thing. Although, they are in the same area / component.
I'm not sure about the nuance here, and need help understanding. If there is a good reason why we need to swap them, then yes, your suggestion of "aria-labelledby when dialog_label is provided" seems right.
Updated•4 months ago
|
Comment 16•4 months ago
|
||
What is the guidance to move forward with the bug. Please :thecount
Comment 17•2 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
Description
•