2008178 - Dialog lacks accessible name (Recent activity section > ••• disclosure > Delete from History dialog)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[John Northup]

Steps to Reproduce

Open DevTools. Within the Recent activity section, in any ••• disclosure, activate the Delete from History button. Using the Accessibility Inspector, inspect the resulting dialog container.

Expected Behavior

name describes the dialog.

Actual Behavior

name is undefined.

User Impact

User may not be fully aware of context.

WCAG 2.2 References

• WCAG 4.1.2 - Name, Role, Value

Recommendations

Use aria-labelledby to reference the visible Edit Shortcut heading.

Testing Environment

Any

Assistive Technology Used

Any

Code Pointers

<div class="modal">

Further Reference

• W3C WAI APG: Modal Dialog Example

Comment 1

[John Northup]

Attachment: Delete from History dialog

Comment 2

[Ina Popescu, Desktop QA]

The issue can be seen as described by the reporter in Nightly 149.0a1. Marking as NEW.

Comment 3

[Anna Yeddi [:ayeddi]]

Issue is similar to the bug 2008180

Comment 4

[Anna Yeddi [:ayeddi]]

Assigning the Severity value to align with the Accessibility severity, per discussions with :thecount and :marco

Comment 5

[Sameeksha]

Hi, I can reproduce this issue locally and I would like to work on it

Comment 6

[Sameeksha]

Attachment: Bug 2008178 - Add accessible name to ConfirmDialog using aria-labelledby. r=thecount

Comment 7

[Sameeksha]

Attachment: Before Patch.png

Before patch: The dialog did not have an accessible nameit was null

Comment 8

[Sameeksha]

Attachment: After Patch.png

After patch: The dialog now correctly uses the header text as its accessible name. In this case it shows: "Are you sure you want to delete every instance of this page from history?"

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d35f952e9507
https://hg.mozilla.org/integration/autoland/rev/7d87dd17f270
Add accessible name to ConfirmDialog using aria-labelledby. r=thecount,home-newtab-reviewers,kcochrane

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/7d87dd17f270

Comment 11

[Sameeksha]

Thank you Kelly and Scott for reviewing and accepting my patch! I had worked on documentation and code cleanup contributions before but this was my first time working on actual component logic. I learned a lot from this and look forward to contributing more!🙌