Dialog not programmatically identified as modal (Recent activity section > ••• disclosure > Delete from History dialog)
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
People
(Reporter: john.northup, Assigned: farmisen, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: access, good-first-bug, Whiteboard: [outreachy-sidebar-2026])
Attachments
(4 files, 1 external file, 2 obsolete files)
|
75.40 KB,
image/png
|
Details | |
|
1.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.08 KB,
patch
|
Details | Diff | Splinter Review | |
|
67.78 KB,
image/png
|
Details |
Steps to Reproduce
Open DevTools. Within the Recent activity section, in any ••• disclosure, activate the Delete from History button. Inspect the resulting dialog container.
Expected Behavior
Dialog container has aria-modal="true".
Actual Behavior
Dialog container lacks the aria-modal attribute.
User Impact
Semantic information diluted.
WCAG 2.2 References
Best practice only. While aria-modal="true" adds semantic information, its absence does not constitute a WCAG failure provided the dialog itself is properly implemented and announced.
Recommendations
Apply aria-modal="true" to the dialog container. This is the clearest, least fragile way to convey "this is modal" to screen readers.
Testing Environment
Any
Assistive Technology Used
Any
Code Pointers
<div class="modal">
Further Reference
| Reporter | ||
Comment 1•10 months ago
|
||
Updated•10 months ago
|
Comment 2•9 months ago
|
||
The issue can be seen as described by the reporter in Nightly 149.0a1. Marking as NEW.
Updated•8 months ago
|
“I’m interested in this bug as a backup for my Outreachy first contribution. My main bug is #2008131.”
Updated•7 months ago
|
hello,
Please find attached my PATCH for bug 2008189- Add Open Tabs Panel to Sidebar in Firefox Desktop. This modifies -AboutNewTabResourceMapping.sys.mjs. Ready for review
Thank you
Jacqueline Iwu
hi,
I have completed my contribution for this bug. PATCH file attached: 0001-Edited-AboutNewtabResourceMapping.js- for outreachy.patch.
Changes include the required edits to : AboutNewtabResourceMapping.js.
Author: Jacqueline Iwu
awoutreacafrik@gmail.com
Thank you
Dear Mentor Nikkis,
Find attached "updated Patch with corrected commit message a you requested"
Jacqueline Iwu
Comment 8•7 months ago
|
||
John, can you please share where you found that modal? I'm not sure where to be looking for "recent activity" and no similar modals pop up for the Sidebar or Firefox View History items.
| Reporter | ||
Comment 9•7 months ago
|
||
To trigger the modal, open a new tab showing the Firefox Home (Default) page, scroll down to the "Recent activity" section, open a menu associated with one of the items, and click "Delete from History".
Comment 10•7 months ago
|
||
Updated•6 months ago
|
Comment 11•4 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
Comment 12•2 months ago
|
||
I'd like to grab this bug. WIP patch should be done soon.
Comment 13•2 months ago
|
||
Comment 14•2 months ago
|
||
As best I can tell, this one-line change to the ConfirmDialog component is sufficient for adding the desired ARIA attribute to the modal's <div>.
Are there any tests I should run before I submit for review? (Or, any other feedback?)
Updated•2 months ago
|
Updated•2 months ago
|
Comment 15•2 months ago
|
||
Apologies for the delay. I can see you abandoned the patch. Are you still interested in working on this? If so, I'll had over to the New Tab team who have more context on this. Thank you!
Comment 16•2 months ago
|
||
Yeah, still interested!
I thought I had created a duplicate Phab page, and tried to abandon the old one, but somehow managed to abandon both.
Comment 17•16 days ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 18•1 day ago
|
||
The dialog is opened with showModal(), which already exposes the modal
state to assistive technology. Add aria-modal="true" on the dialog
element as well, as the explicit best practice the bug asks for.
Updated•1 day ago
|
Description
•