2008327 - [unified trust panel] broken lock icon in panel-popup is too hard to see, in dark mode theme

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Toggle dark mode in your OS.
2. Visit http://http.badssl.com/ (note, this is an insecure http-only website)
3. Click the unified trust panel ("not secure" badge at left edge of URL)
4. Look for the broken lock icon about half way down the panel (inside the red box)

ACTUAL RESULTS:
Lock is hard to see -- its drawn as a black lock-outline on a dark-red background, which doesn't have much contrast.

EXPECTED RESULTS:
Lock outline should probably be white, so that the lock can be seen. (Note that before we enabled the Unified Trust Panel, the analogous UI had a white-colored lock, which shows up nicely.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot in light OS theme for comparison

Here's a screenshot with the light OS theme for comparison, where the lock consistently has a black outline and it's quite easy to see.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1988726

:daleharvey, since you are the author of the regressor, bug 1988726, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Dale Harvey (:daleharvey)]

Not yet enabled on release

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 2008327 - Ensure trustpanel padlock icon uses theme color. r=dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50e377eea925
https://hg.mozilla.org/integration/autoland/rev/c1285e65b847
Ensure trustpanel padlock icon uses theme color. r=desktop-theme-reviewers,jules

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c1285e65b847

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1988726