1988726 - Enable trustpanel in nightly by default

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Dale Harvey (:daleharvey)]

Once https://bugzilla.mozilla.org/show_bug.cgi?id=1976113 has landed and QA has had a chance to smoke test the implementation we can enable in nightly by default

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1988726 - Enable trustpanel in nightly.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1988726 - Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7f8c6db43596
https://hg.mozilla.org/integration/autoland/rev/2082a0b1cecf
Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55f4bfa055a9
https://hg.mozilla.org/integration/autoland/rev/9c5a1b4224c4
Revert "Bug 1988726 - Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn" for causing wpt failures @ open-features-negative-innerwidth-innerheight.html

Comment 5

[amarc]

Backed out for causing wpt failures

• Backout link
• Push with failures
• Failure Log
• Failure log 2
  Failure Log 3
  Failure Log 4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a2e37315c4de
https://hg.mozilla.org/integration/autoland/rev/b4dede19fd99
Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn,desktop-theme-reviewers,dao

Comment 7

[Dale Harvey (:daleharvey)]

Ok I could reproduce the wpt tests and they are fixed

browser/components/extensions/test/browser/browser_ext_popup_corners.js is a test failure I have been seeing in runs but this test has never passed for me locally at all? There doesnt seem to be any restrictions on what platform it runs on try, but I attempted disabling trustpanel for it and either way it seems like a permafail.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a2586e4723b7
https://hg.mozilla.org/integration/autoland/rev/c98a3e284347
Revert "Bug 1988726 - Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn,desktop-theme-reviewers,dao" for causing bc failures on browser_ext_popup_corners.js

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_ext_popup_corners.js

Push with failures

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=539151418&repo=autoland&task=RFFKQQZRSr-DdkMUBX9neg.0
• https://treeherder.mozilla.org/logviewer?job_id=539147303&repo=autoland&task=BNE4NdbASbib8OK9wJYArw.0

Backout link

Comment 10

[Dale Harvey (:daleharvey)]

Ok apologies for that, as said I am very confused as this test never passes for me, testing a try run with trustpanel disabled though

Comment 11

[Cosmin Sabou [:CosminS]]

There's also this browser accessible failure: https://treeherder.mozilla.org/logviewer?job_id=539147303&repo=autoland&task=BNE4NdbASbib8OK9wJYArw.0&lineNumber=17894

Comment 12

[Dale Harvey (:daleharvey)]

Ok thank I wasnt coming across that one in my default runs, disabling trustpanel for these test seems to work, I think we are good to go now just waiting on the test run @ https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167956

Comment 13

[Dale Harvey (:daleharvey)]

Ok so the issue with browser_ext_popup_corners was that it doesnt pass if you run the test by itself which means all my previous runs would flag the test to run when I disabled trustpanel, meaning it would fail as verify would run it standalone.

I have verified doing a full directory run that trustpanel disabling does fix this test although its still gonna fail if a verify runs on the commit, have filed https://bugzilla.mozilla.org/show_bug.cgi?id=2005158 to fix that. I think we are good to go now.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e3b998d8544e
https://hg.mozilla.org/integration/autoland/rev/31298ba1737e
Enable trustpanel in nightly. r=webcompat-reviewers,extension-reviewers,credential-management-reviewers,places-reviewers,omc-reviewers,willdurand,emz,twisniewski,daisuke,dimi,emcminn,desktop-theme-reviewers,dao

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/31298ba1737e

Comment 16

[Donal Meehan [:dmeehan]]

:daleharvey, could you consider nominating this for a release note? (Process info)

Comment 17

[Dale Harvey (:daleharvey)]

Have put the relnote in https://bugzilla.mozilla.org/show_bug.cgi?id=2008405