2008429 - No search term history entry if change search engine.

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Alice0775 White]

Steps to reproduce:

1. Enable new Search bar (browser.search.widget.new = true)
2. Search several words with the default engine
3. Clear text in the new Search bar if any
4. Change search engine(default or other engine) from urlbar-searchmode-switcher button
5. Key press [ArrowUp] key in the new Search bar

Actual results:
No search term history entry.
So, it is impossible to search with the changed engine from search history.

Expected results:
All search term history entries should be listed.

Comment 1

[Alice0775 White]

And
When searching using a search engine other than the default, search terms are not saved as search history.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2008429 - Ignore search mode for recent searches and form history search suggestions in searchbar. r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/78fd16667ddb
https://hg.mozilla.org/integration/autoland/rev/1dc596aaf192
Ignore search mode for recent searches and form history search suggestions in searchbar. r=dao,urlbar-reviewers

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1dc596aaf192

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox148 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Petruta Horea [:phorea]]

Reproduced the issue described, the previous behaviour was similar to the address bar.

In latest 149.0a1 Nightly, the recent searches (5 by default) are displayed also in search mode or after changing the default search engine. Verified across platforms.