2008530 - Statically initialize the MathML unicode table for stretchy operators

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang Nélar]

nsGlyphTableList only contains a single item, which is the unicode table.

Comment 1

[Frédéric Wang Nélar]

Attachment: Bug 2008530 - Part 1 Statically initialize the MathML unicode table for stretchy operators. r=emilio

Comment 2

[Frédéric Wang Nélar]

Attachment: Bug 2008530 - Part 2 - Use `nsGlyphTable::IsUnicodeTable()` instead of raw pointer comparison. r=emilio

glyph table == &gUnicodeTable is used in three places with the glyph
table nullptr in nsMathMLChar::SetFontFamily when called from
https://searchfox.org/firefox-main/rev/e61d59b5c9a651fd7bf28043f87c0dc669833496/layout/mathml/nsMathMLChar.cpp#1279

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e216f0f8869
https://hg.mozilla.org/integration/autoland/rev/de27e9ea6a87
Part 1 Statically initialize the MathML unicode table for stretchy operators. r=layout-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/7a3c4b556acb
https://hg.mozilla.org/integration/autoland/rev/41988b51abf1
Part 2 - Use `nsGlyphTable::IsUnicodeTable()` instead of raw pointer comparison. r=layout-reviewers,dshin,sergesanspaille

Comment 4

[agoloman]

Backed out for causing build bustages @nsMathMLChar.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Frédéric Wang Nélar]

(In reply to agoloman from comment #4)

Backed out for causing build bustages @nsMathMLChar.cpp.

• Backout link
• Push with failures
• Failure Log

This was caused by MOZ_COUNT_CTOR/DTOR for Bloatview. I remove them and deleted the new operators, since this is no longer supposed to be used on the heap.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/97881a44751d
https://hg.mozilla.org/integration/autoland/rev/5d6b31564de0
Part 1 Statically initialize the MathML unicode table for stretchy operators. r=layout-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/2da44da5de3b
https://hg.mozilla.org/integration/autoland/rev/3027997e7f92
Part 2 - Use `nsGlyphTable::IsUnicodeTable()` instead of raw pointer comparison. r=layout-reviewers,dshin,sergesanspaille

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5d6b31564de0
https://hg.mozilla.org/mozilla-central/rev/3027997e7f92