2008571 - Allow scroll snap for APZ pixel mouse wheel scrolls

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P2)

Description

[Dan Robertson (:dlrobertson)]

As part of Bug 1753188 we should allow APZ to call scroll snap for mousewheel pixel scrolls.

Comment 1

[Dan Robertson (:dlrobertson)]

Attachment: Bug 2008571 - Scroll snap for mousewheel pixel scrolls. r=hiro

Allow APZ to call scroll snap for mousewheel pixel scrolls.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:hiro, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Setting P2:S3 since I believe this will be a part of interop-2026.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14c694ce058a
https://hg.mozilla.org/integration/autoland/rev/cd2605aa8601
Scroll snap for mousewheel pixel scrolls. r=hiro

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e772f8131a67
https://hg.mozilla.org/integration/autoland/rev/ec0f40c33068
Revert "Bug 2008571 - Scroll snap for mousewheel pixel scrolls. r=hiro" for causing wpt failures @snap-at-user-scroll-end.html.

Comment 6

[agoloman]

Backed out for causing wpt failures @snap-at-user-scroll-end.html.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Dan, you can land D277885 as it is, once after bug 2019485 has been merged into m-c, or land it now on autoland unless bug 2019485 is backed out.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I landed on phabricator, it hasn't yet been landed on autoland becasue the tree is now closed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c1262a22e00
https://hg.mozilla.org/integration/autoland/rev/1be0208a8b10
Scroll snap for mousewheel pixel scrolls. r=hiro

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/700cc6ff749b
https://hg.mozilla.org/integration/autoland/rev/2d90786a4e3e
Revert "Bug 2008571 - Scroll snap for mousewheel pixel scrolls. r=hiro" for causing failures at scroll-marker-selection-in-padded-scroller.html.

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Re-landed with tweaking the annotation for scroll-marker-selection-in-padded-scroller.html. The test was merged into m-c on Feb. 4th. I suppose Dan wasn't aware of it.

Comment 12

[Atila Butkovits]

Backed out for causing failures at scroll-marker-selection-in-padded-scroller.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/2d90786a4e3e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1be0208a8b105560bf64f0011ffd0b620ec35e0d&selectedTaskRun=ALh8s1BPSk682kCm-xJrPw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=550940727&repo=autoland&task=ALh8s1BPSk682kCm-xJrPw.0&lineNumber=2762

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20576d1f8a3a
https://hg.mozilla.org/integration/autoland/rev/a89af4e84409
Scroll snap for mousewheel pixel scrolls. r=hiro

Comment 14

[rperta]

https://hg.mozilla.org/mozilla-central/rev/a89af4e84409