2009192 - Document PiP is closed when moving opener between windows

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Vincent Hilla [:vhilla]]

Attachment: test.html

STR

• Open test case, click the button
• Move the tab with the test case to another window

Expected

• The PiP window stays open

Actual

• The PiP window is closed

---

I think this is not severe (doesn't need to block landing), but it works in Chrome and could be slightly annoying to users.

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: test.html

Comment 2

[Vincent Hilla [:vhilla]]

Bug 2008334 will need to test that adopting the PiP opener doesn't mess with window activity. So I've also looked a bit at why tab adoption closes the PiP.

https://pernos.co/debug/uNWDbgoPE09LFMzlKOiu9g/index.html

We call Document::CloseAnyAssociatedDocumentPiPWindows due to a page hide from nsContentUtils::FirePageHideEventForFrameLoaderSwap, which is called from BrowserChild::RecvSwappedWithOtherRemoteLoader. But I don't know enough about frame loader swap in Gecko. Maybe we can special-case this pagehide or should call CloseAnyAssociatedDocumentPiPWindows from somewhere else.