2006594 - Enable Document Picture-in-Picture on Desktop in release

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: Bug 2006594 - Ship Document Picture-in-Picture API. r=edgar

Comment 2

[Vincent Hilla [:vhilla]]

Description:

The Document Picture-in-Picture API is an always-on-top popup. It has an additional "Return" button to get back to the opener and some browser UI elements are hidden.
It's an API exposed by the web, therefore user scenarios depend on the page. Pages might put audio controls in this popup, show a custom media player rather than using the existing Video Picture-in-Picture, or do simple things like showing a stopwatch. In general: The user interacts with the page, the popup opens and gains focus, the user interacts with the popup and at some point (a) closes it like any other window (b) closes it via the return button so focus moves back to the opener page or (c) an action is performed that auto-closes the popup.

How do we test this?

The API is behind the dom.documentpip.enabled pref that is enabled nightly-only. I'll add a simple test page to this bug.

When will this ship?

Soon, if bug 2008334 lands and the a11y review completes.
Tracking bug/issue: this bug

Please describe the accessibility guidelines you considered and what steps you've taken to address them:

I went through the guidelines to make sure we follow them. Controls are semantically hidden, buttons come from the native host language. The image icon on the return button doesn't have an alt text, but other browser UI buttons don't have either.

Describe any areas of concern to which you want the accessibility team to give special attention:

• Always-on-top windows aren't new to Firefox, but maybe there are concerns about them?
• The spec requires the window to be closed on certain disallowed operations. E.g. if the user navigates or reloads the opener or popup. Could the window disappearing be an issue? Also see bug 2019895.
• There is a new "Return" button introduced in the browser UI.

Comment 3

[Vincent Hilla [:vhilla]]

Attachment: example.html

Comment 4

[Natalie Stroud [:nstroud]]

Hey Vincent! Thank you for sending this over (: I'm starting on this now but if you need anything, please let me know!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45c10db45b38
https://hg.mozilla.org/integration/autoland/rev/59224676b0ea
Ship Document Picture-in-Picture API. r=edgar,webidl,smaug

Comment 6

[Vincent Hilla [:vhilla]]

Regarding dev-doc-needed, see bug 1858562#c26. I think it only needs to be added to the release notes.

---

For the release note request, I'm paraphrasing 1858562#c22:

[Why is this notable]: New web API
[Affects Firefox for Android]: No
[Suggested wording]: Firefox now supports the Document Picture-in-Picture API, which allows web pages to place content in an always-on-top popup.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Document_Picture-in-Picture_API

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/59224676b0ea

Comment 8

[Donal Meehan [:dmeehan]]

Added to the Fx151 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx151 release notes.

Comment 9

[Hamish Willee]

FF151 MDN work for this can be tracked in https://github.com/mdn/content/issues/43861. Docs are good. This is just a release note an compatibility data update.

Comment 10

[Donal Meehan [:dmeehan]]

Added to the final Fx151 release notes