2009660 - Move Document PiP window to default position when entering fullscreen

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Vincent Hilla [:vhilla]]

Let's move the document PiP windows out of the way when entering fullscreen so that it doesn't interfere with anything.

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: Bug 2009660 - Move Document PiP windows away when entering fullscreen. r=edgar,#dom-core

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a94dc909980d
https://hg.mozilla.org/integration/autoland/rev/dd87e68c59cc
Revert "Bug 2009660 - Move Document PiP windows away when entering fullscreen. r=edgar,dom-core" for causing lint failures.

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/dd87e68c59ccfc340cdbb19030f2bd57c2629b01

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/documentpip/tests/browser/browser_move_pip_for_fullscreen.js:13:9 | 'movePiP' is not defined. (no-undef)

Comment 4

[Vincent Hilla [:vhilla]]

Oh right, this patch depends on the test utility from bug 2006642. I'll wait a bit till that change has landed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ffb1e8cf7cc
https://hg.mozilla.org/mozilla-central/rev/db38c24f9331
Move Document PiP windows away when entering fullscreen. r=edgar,dom-core

Comment 6

[Vincent Hilla [:vhilla]]

I got confused by the comment 5 coming after the revert and thought someone else landed this again. Bug 2006642 is fixed, so I rebased the patch and will land now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4220cbd9fbc1
https://hg.mozilla.org/integration/autoland/rev/f0ec8848848d
Move Document PiP windows away when entering fullscreen. r=edgar,dom-core

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f0ec8848848d