2009908 - Display ::picker-icon pseudo element in markup view

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Those are displayed in Chrome DevTools, so let's do the same

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Mathew, unless I'm missing something, at the moment it doesn't seem like we can set CSS to the ::picker-icon pseudo element? (I tried setting a color/background-color, which does work in Chrome, but not in Firefox, even with layout.css.appearance-base.enabled set to true)
If I'm not wrong, do we have a bug where this is going to be implemented, so I can mark it as blocker for this bug and know where we need to look into the DevTools support.
Thanks!

Comment 2

[Keith Cirkel [:keithamus]]

I created Bug 2044945 just to tackle both this and Bug 2009911

Comment 3

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 2009908 - Handle ::picker-icon in InspectorUtils::GetChildrenForNode. r=keithamus.

Comment 4

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 2009908 - [devtools] Display ::picker-icon nodes in markup view. r=#devtools.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5e0bfdcf9023
https://hg.mozilla.org/integration/autoland/rev/3a956df98b09
Handle ::picker-icon in InspectorUtils::GetChildrenForNode. r=keithamus,layout-reviewers,emilio.
https://github.com/mozilla-firefox/firefox/commit/c39732074c1d
https://hg.mozilla.org/integration/autoland/rev/2c059f62d6f0
[devtools] Display ::picker-icon nodes in markup view. r=devtools-reviewers,ochameau.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3a956df98b09
https://hg.mozilla.org/mozilla-central/rev/2c059f62d6f0