2044275 - Show ::picker element instead of SelectParent when `appearance:base`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2044275 - Sort all UA rules in the same batch. r=keithamus,#style

This is more consistent and allows specificity and rule source order to
work as intended.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/557a2c952304
https://hg.mozilla.org/integration/autoland/rev/6cbf8b8ba648
Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c04e3ee22d72
https://hg.mozilla.org/integration/autoland/rev/3b795085cf78
Revert "Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio" for causin wr test failures at /css/css-contain/contain-size-select-elem-003.html

Comment 5

[Silaghi Andreea]

Backed out for causing wr and wpt test failures at /css/css-contain/contain-size-select-elem-003.html
Backout Link
Push with failures
Failure Log
wpt failures
Failure line TEST-UNEXPECTED-FAIL | /css/css-contain/contain-size-select-elem-003.html | Testing http://web-platform.test:8000/css/css-contain/contain-size-select-elem-003.html == http://web-platform.test:8000/css/css-contain/contain-size-select-elem-003-ref.html

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b2d037c6a52
https://hg.mozilla.org/integration/autoland/rev/9ff69418f818
Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b749b8eb067f
https://hg.mozilla.org/integration/autoland/rev/615c3d6f44f3
Revert "Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio" for causing wpt failures at accessibility-minimum-target-size.html

Comment 8

[Silaghi Andreea]

Backed out for causing wpt, bc and wr failures at /select-accessibility-minimum-target-size.html and at css/css-contain/contain
Backout Link
Push with failures wpt
Push with failures wr
Failure Log wpt
wr
bc
Failure lines:
TEST-UNEXPECTED-PASS | /html/semantics/forms/the-select-element/customizable-select/select-accessibility-minimum-target-size.html | horizontal-tb "i": Select with appearance:base-select should have targets for pointer inputs be at least 24x24 CSS pixels. - expected FAIL
TEST-UNEXPECTED-FAIL | /css/css-contain/contain-size-select-elem-003.html | Testing http://web-platform.test:8000/css/css-contain/contain-size-select-elem-003.html == http://web-platform.test:8000/css/css-contain/contain-size-select-elem-003-ref.html

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e5496e9b6f78
https://hg.mozilla.org/integration/autoland/rev/a4e7647f46cc
Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd3f43d5b811
https://hg.mozilla.org/integration/autoland/rev/ab7ad991dee6
Revert "Bug 2044275 - Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio" for causing failures at contain-size-select-elem-003.html.

Comment 11

[Atila Butkovits]

Backed out for causing failures at contain-size-select-elem-003.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ab7ad991dee6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=QyLU0NdhSwacOWclzb8ujA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a4e7647f46ccdb4554dcc579521a4cc155dfa226

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=574705775&repo=autoland&task=QyLU0NdhSwacOWclzb8ujA.0&lineNumber=14681
https://treeherder.mozilla.org/logviewer?job_id=574722229&repo=autoland&task=SkT-K0XgR9OrxRRPWy1c1A.0&lineNumber=14970
https://treeherder.mozilla.org/logviewer?job_id=574722230&repo=autoland&task=EXjVtP12SLyOV_8nrjUW9g.0&lineNumber=14144
https://treeherder.mozilla.org/logviewer?job_id=574724867&repo=autoland&task=brWD0am-TVKw3R2e6jtkaQ.0&lineNumber=25383

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0772f850bc1e
https://hg.mozilla.org/integration/autoland/rev/893d9d0dad63
Wire up ::picker, showing instead of SelectParent when appearance:base r=firefox-style-system-reviewers,emilio

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/893d9d0dad63

Comment 14

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8e52451d956b
https://hg.mozilla.org/integration/autoland/rev/98246339b79d
Sort all UA rules in the same batch. r=keithamus

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/98246339b79d