Closed
Bug 201046
Opened 22 years ago
Closed 21 years ago
Rename Elapsed Time to Time Elapsed
Categories
(Core Graveyard :: File Handling, enhancement)
Core Graveyard
File Handling
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Lil46john, Assigned: law)
References
Details
(Keywords: helpwanted, polish)
Attachments
(1 file)
771 bytes,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030407 Phoenix/0.5+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030407 Phoenix/0.5+
The Download Dialog should say Time Elapsed to be consistent with Download Manager
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
.
Assignee: blaker → law
Component: Download Manager → File Handling
Updated•22 years ago
|
Keywords: helpwanted
Comment 2•22 years ago
|
||
Well, this is not one of Mozilla's most urgent problems.
But I'll confirm it because it looks a bit better ("Time" being in the first
position at both occurrances).
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•22 years ago
|
||
Change the wording.
Comment 4•22 years ago
|
||
Comment on attachment 120075 [details] [diff] [review]
patch
Requesting review from law@netscape.com.
Please tell me if sr= is needed for such a small change.
And I have no CVS write access, so...
Attachment #120075 -
Flags: review?(law)
Does progress dialog make use of the embedded dtd file or the one under the xfer
component? I've a feeling both might need to be patched.
Comment 6•21 years ago
|
||
Comment on attachment 120075 [details] [diff] [review]
patch
law is gone... requesting review from someone who still works on mozilla
Attachment #120075 -
Flags: review?(law) → review?(bzbarsky)
Comment 7•21 years ago
|
||
Comment on attachment 120075 [details] [diff] [review]
patch
Actually, biesi, would you mind doing the r=? The change is good as far as I
am concerned. Ian, please poke me for checkin via email once this has r=.
We should also consider removing downloadProgress.dtd -- it seems unused...
Attachment #120075 -
Flags: superreview+
Attachment #120075 -
Flags: review?(cbiesinger)
Attachment #120075 -
Flags: review?(bzbarsky)
Can I refer people back to comment#5, this patches the nsProgressDialog.dtd
under embedding but not downloadProgress.dtd under xpfe/components/xfer. Surely
this patch should address both?
Comment 9•21 years ago
|
||
Ian: see comment 7 and
http://lxr.mozilla.org/seamonkey/search?string=downloadProgress.dtd, that file
seems unused
Updated•21 years ago
|
Attachment #120075 -
Flags: review?(cbiesinger) → review+
Comment 10•21 years ago
|
||
oh... it seems like downloadProgress.dtd was made unused by the removal of
nsProgressDlg.{xul,js} in bug 211169... sorry for not noticing that :/
Comment 11•21 years ago
|
||
Hmmm, so that was the rug that went from under me.
Comment 12•21 years ago
|
||
Patch checked in. r/sr=me to remove that unused file, biesi....
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 13•21 years ago
|
||
ok, that file is gone, together with the jar.mn entry for it
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•