2010551 - Re-enable custom review prompt

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Marcin Koziński]

Provided we won't prompt people repeatedly anymore, enable the custom prompt UI again, to start prompting for better reviews.

Comment 1

[Marcin Koziński]

Attachment: Bug 2010551 - Re-enable custom review prompt

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/85726dd9ed6a
https://hg.mozilla.org/integration/autoland/rev/f0c132f20912
Re-enable custom review prompt r=android-reviewers,twhite

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f0c132f20912

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: If declined we'll continue to prompt for reviews in a non-optimised way, resulting in lower average rating.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: We've investigated the issue for a long time and are confident in our understanding of what caused the prompt to show repeatedly. We've verified the fix in manual testing on debug and nightly builds. If we're still wrong, the worst that could happen is we regress the repeated prompts issue, which happens for a small fraction of % of people.
• String changes made/needed: no
• Is Android affected?: yes

Comment 5

[Marcin Koziński]

Attachment: Bug 2010551 - Re-enable custom review prompt

Original Revision: https://phabricator.services.mozilla.com/D279261

Comment 6

[Marcin Koziński]

Attachment: Bug 2010551 - Re-enable custom review prompt

Original Revision: https://phabricator.services.mozilla.com/D279261

Comment 7

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: If declined we'll continue to prompt for reviews in a non-optimised way, resulting in lower average rating.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: We've investigated the issue for a long time and are confident in our understanding of what caused the prompt to show repeatedly. We've verified the fix in manual testing on debug and nightly builds. If we're still wrong, the worst that could happen is we regress the repeated prompts issue, which happens for a small fraction of % of people.
• String changes made/needed: no
• Is Android affected?: yes

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Given all the issues we've had with this in the past, I'd like to see this get some more bake time than it's going to get before I need to build the planned 147.0.2 dot release going out early next week. We can leave this on the radar to ride along if there's another dot release later this cycle, however.

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5c8a84778356
https://hg.mozilla.org/releases/mozilla-beta/rev/8a8a762a66b4