Closed Bug 2010901 Opened 3 months ago Closed 2 months ago

Stay in Smart Window View across Firefox restart (for single current window)

Categories

(Core :: Machine Learning: Frontend, defect, P1)

Desktop
All
defect
Points:
1

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox-esr140 --- disabled
firefox147 --- disabled
firefox148 --- disabled
firefox149 --- verified

People

(Reporter: Gijs, Assigned: jlewis)

References

(Blocks 1 open bug)

Details

(Whiteboard: [genai][switcher])

Attachments

(1 file)

STR:

  1. current nightly, have only 1 window open, enable the smart window pref
  2. Open Settings, Go to General and under startup check 'Open previous windows and tabs' ( this sets pref browser.startup.page to 3)
  3. switch current window into smart window
  4. Restart Nightly

ER: On restart Nightly should stay in smart window view

AR: back to classic view

Blocks: 1992301

The severity field is not set for this bug.
:Mardak, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(edilee)

The severity field is not set for this bug.
:Mardak, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(edilee)

i've attached the hackalong patch but for reference, here's how the same restoreWindowFeatures method handled it on the demo build https://github.com/Firefox-AI/firefox-prototypes/blob/6d4eeae66d4e1d8997e6798ce4adf678111d3a3f/browser/components/sessionstore/SessionStore.sys.mjs#L6573-L6576

Assignee: nobody → jlewis
Severity: -- → S2
Points: --- → 1
Flags: needinfo?(edilee)
Priority: -- → P1
Attachment #9541897 - Attachment description: WIP: Bug 2010901 - Stay in Smart Window View across Firefox restart (for single current window) → Bug 2010901 - Stay in Smart Window View across Firefox restart (for single current window) r=#ai-frontend-reviewers
Duplicate of this bug: 2016131

Will this also cover the "Restore previous windows and tabs" option being checked from about:preferences ?

(In reply to Rares Doghi, Desktop QA from comment #6)

Will this also cover the "Restore previous windows and tabs" option being checked from about:preferences ?

Yes. This already works, "just" not for a single window. Try with multiple windows (all but the initial/one window will work correctly).

I tried this with multiple Smart Windows without any Classic windows opened:
For the first try after reopening Firefox it only opened one Classic Window.
2nd Try same scenario I got one Smart Window and one Classic Window, I will keep testing this.
Does it matter if we close it by Hamburger menu > Exit or simply Right clicking the Firefox in the Windows bar and selecting Close Firefox ?

Pushed by jlewis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/75a7b191fae0 https://hg.mozilla.org/integration/autoland/rev/9070721b195b Stay in Smart Window View across Firefox restart (for single current window) r=ai-frontend-reviewers,sessionstore-reviewers,mlucks,sfoster
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch

(In reply to Rares Doghi, Desktop QA from comment #8)

I tried this with multiple Smart Windows without any Classic windows opened:
For the first try after reopening Firefox it only opened one Classic Window.
2nd Try same scenario I got one Smart Window and one Classic Window, I will keep testing this.
Does it matter if we close it by Hamburger menu > Exit or simply Right clicking the Firefox in the Windows bar and selecting Close Firefox ?

How you quit as long as Firefox is completely ended should not matter. Not 100% sure I follow the other descriptions - but either way I expect everything should be fixed in a Nightly with the patch from this bug. Could you verify? If there's more to do we'd like to know ASAP

Flags: needinfo?(rdoghi)

Yes this issue is indeed Verified as fixed in our latest Nightly 149.0a1 (2026-02-12)
This also fixes the Restart with a single or multiple windows as well as Closing and then Starting Firefox with a single or multiple windows.

All windows are restored if the user restores the Previous session from History menu or for having the "Restore previous windows and tabs" option checked.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-done-c149/b148]
Flags: needinfo?(rdoghi)
QA Contact: rdoghi

Authored by https://github.com/Mardak
https://github.com/mozilla/enterprise-firefox/commit/75a7b191fae0cd12fd6ee8bd769f1a67e8b0d50d
[enterprise-main] Bug 2010901 - Stay in Smart Window View across Firefox restart (for single current window) r=ai-frontend-reviewers,sessionstore-reviewers,mlucks,sfoster

Status: VERIFIED → RESOLVED
Closed: 3 months ago2 months ago
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: