2011056 - Handle OwnPropertyKeys according to the spec

Status: ASSIGNED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jonathan Kingston [:jkt] he/him]

Per the WebIDL specification, [[OwnPropertyKeys]] for the named properties object should return only @@toStringTag. Named properties should be resolved via [[GetOwnProperty]] but not enumerated as own keys.

Spec reference: https://webidl.spec.whatwg.org/#named-properties-object

Currently, WindowNamedPropertiesHandler::ownPropNames enumerates child browsing context names and document-exposed names when JSITER_HIDDEN is set. This is incorrect per spec.

See in https://bugzilla.mozilla.org/show_bug.cgi?id=1730243 test fails.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 2011056 - Handle OwnPropertyKeys according to the spec r?smaug

Depends on D279095

Comment 2

[Jonathan Kingston [:jkt] he/him]

I think you'll have to send this to lando, I don't have l3 access anymore. Thanks for the review!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f63bd5a50fd4
https://hg.mozilla.org/integration/autoland/rev/1a641a1daffd
Handle OwnPropertyKeys according to the spec r=tschuster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/69888f58354c
https://hg.mozilla.org/integration/autoland/rev/354c926233a2
Revert "Bug 2011056 - Handle OwnPropertyKeys according to the spec r=tschuster" for causing failures at test_window_element_enumeration.html.

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_window_element_enumeration.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/354c926233a2

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1a641a1daffd2a05b3124a4e531fc861b2a49bc9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=545333903&repo=autoland&task=WwlBiXi8TAC6Pci57trhqA.0&lineNumber=4549