2011351 - TextInputDelegateTest doesn't play well with nsPresContext::UserInputEventsAllowed

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Ted Campbell [:tcampbell]]

The UserInputEventsAllowed check in the DOM doesn't play well with our test cases and seems to be one source of flakiness. On desktop, we mark such keyboard events during tests as synthetic, but that is a bit clumsy with out tests that use InputConnection.
As a simple fix, I'll just change the pref while the TextInputDelegateTests run.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 2011351 - Disable dom_input_events_security during TextInputDelegateTest. r?m_kato

Synthetic tests can be flaky if they run faster than the input check so disable it
for the test. Note that on desktop we mark such inputs as synthetic to bypass the
check, but that is more awkward in our Android tests that are using InputConnection.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 2011351 - Re-enable some TextInputDelegateTest tests r?m_kato

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8ede01d01d0c
https://hg.mozilla.org/integration/autoland/rev/eade32239c65
Disable dom_input_events_security during TextInputDelegateTest. r=m_kato,geckoview-reviewers

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eade32239c65

Comment 5

[Ted Campbell [:tcampbell]]

The remaining inputConnection_setSelection test is still flaky due to race condition here. If I remove the guard and always send the message then the test reliably works for me. The problem is that check was added to fix Bug 1563640. I tried to reproduce on Fennec68/Pixel3/SwiftKey7.7 but was not able to (probably because my OS is updated). Without more insight into that old bug I'm slightly cautious about changing things even though the current code is itself race-y.

Makoto, do you have any thoughts about if we should try to fix this, or keep the test disabled for now?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6740ae5951d9
https://hg.mozilla.org/integration/autoland/rev/dfc517ba3733
Re-enable some TextInputDelegateTest tests r=m_kato,geckoview-reviewers

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/dfc517ba3733

Comment 8

[Makoto Kato [:m_kato]]

At that time, mobile twitter used another library to input tweet. Currently they use something contenteditable library (draft.js or Lexical) on mobile site.
So please keep setSelection is disabled. I can reproduce original issue on simply <textarea> with the latest version of SwiftKey EN keyboard when backed out original fix.

Also I should add more test case to emulate IME...

Comment 9

[Makoto Kato [:m_kato]]

I added SwiftKey emulation by bug 2012938