2012938 - Add more test cases for bug 1563640

Status: RESOLVED FIXED

(GeckoView :: IME, defect, P3)

Description

[Makoto Kato [:m_kato]]

After dispatching enter key, SwiftKey sets composing selection to previous selection then commit. So I should add this IC calls to junit.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 2012938 - Add a test case for bug 1563640. r=#geckoview-reviewers!

I would like to add a test case to enumerate InputConnection calls by
SwiftKey.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72b356a34b0d
https://hg.mozilla.org/integration/autoland/rev/be14680f473a
Add a test case for bug 1563640. r=geckoview-reviewers,ohall

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c434973873b
https://hg.mozilla.org/integration/autoland/rev/e5d97346a612
Revert "Bug 2012938 - Add a test case for bug 1563640. r=geckoview-reviewers,ohall" for causing junit failures @ TextInputDelegateTest

Comment 4

[amarc]

Backed out for causing junit failures

• Backout link
• Push with failures
• Failure Log
• Failure Log 2

Comment 5

[Makoto Kato [:m_kato]]

Hmm, I cannot reproduce this on local. I need to test more in taskcluster....

Comment 6

[Makoto Kato [:m_kato]]

I am re-thinking a fix of bug 1563640. It is better to ignore update composition during batch edit.

https://treeherder.mozilla.org/jobs?repo=try&revision=9f96851e9797f70202b6bd4b4c61ced6a5dc527b

Comment 7

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=41baacf4d667077c184b7cf870d8f692dcfdbe61

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 2012938 - Ignore updating composition during batch mode. r=#geckoview-reviewers

Original bug (bug 1563640) is that SwiftKey calls meaningless
setComposingRegion() and finishComposingText() when user presses enter
key. Android can have two caret types, one is normal caret and the other
is IME caret. But Gecko has only normal caret. So this SwiftKey's behavior
causes that the caret position is changed unfortunately.

I added a workaround to ignore these. But this causes test failures on some
tests that is disabled now. So this fix re-writes it.

This fix is that we don't update composition immediately during batch mode.
We wait until batch mode is finished and then update composition.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/440bae4b7650
https://hg.mozilla.org/integration/autoland/rev/72cde5f9cfad
Add a test case for bug 1563640. r=geckoview-reviewers,ohall
https://github.com/mozilla-firefox/firefox/commit/acd9cc9240d4
https://hg.mozilla.org/integration/autoland/rev/b215ef0afbeb
Ignore updating composition during batch mode. r=geckoview-reviewers,tcampbell

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/72cde5f9cfad
https://hg.mozilla.org/mozilla-central/rev/b215ef0afbeb