2011427 - Focus border missing/hidden for time-picker

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Dave Letorey]

Attachment: The left hand side of the focus border is missing/hidden four hour field on <input type="time">

The focus border does not fit in the time picker on:

• <input type="time"> for hours
• <input type="datetime-local"> for AM/PM
  This is behind a flag dom.forms.datetime.timepicker

Comment 1

[Dave Letorey]

Attachment: The right hand side of the focus border is missing/hidden four AM/PM field on <input type="datetime-local">

Comment 2

[Dave Letorey]

Related Bugs

• 1726108
• 1990226

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

This is probably a blocker for enabling it, but should be easy to fix... Seems we should just add some padding to the dialog (and remove the outer padding perhaps?).

Actually there are only a couple blockers for enabling the time picker (this one and bug 1990226), and I already got the UX approval otherwise.

Anna you worked on the date picker etc, do you happen to have some spare cycles to look at this? No problems if not, it's just worth a shot :)

Comment 5

[Peter]

I'm also seeing this focus indicator issue (Firefox Stable, adv. pref dom.forms.datetime.timepicker = true). It started after a Firefox update around 5 months ago. The same update also broke numeric keyboard input for time input fields when the picker is open (number keys do nothing when the picker is open, whereas up until 5 months ago they would populate the input field). These timepicker focus problems seem closely related, especially because they came together.

Comment 6

[Sam Johnson]

Attachment: Bug 2011427 - Fix focus outlines for date/time pickers. r?#recomp-reviewers

Applies the outline padding to the container rather than just the date picker so that the time picker outlines don't get clipped. Also corrected the panel sizes to be more precise.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d9c0ebd3676
https://hg.mozilla.org/integration/autoland/rev/b840c55a1bb7
Fix focus outlines for date/time pickers. r=desktop-theme-reviewers,mkennedy,emilio

Comment 8

[rperta]

https://hg.mozilla.org/mozilla-central/rev/b840c55a1bb7