2011504 - Remove code no longer needed after the ICU4X 2.1.1 update

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Remove code no longer needed after bug 1997048, because the functionality is now provided by ICU4X.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2011504 - Part 1: Remove calendar-specific maximum year checks. r=#spidermonkey-reviewers!

We no longer need to apply calendar-specific year checks after the upgrade to ICU4X 2.1.1.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 2011504 - Part 2: Simplify CalendarDateYear. r=#spidermonkey-reviewers!

ICU4X was updated so that icu4x_Date_extended_year_mv1 is now consistent with
Temporal.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 2011504 - Part 3: Remove no longer needed code to adjust eras. r=#spidermonkey-reviewers!

ICU4X can now handle years exceeding a given era, so we no longer have to
adjust era names and years before calling into ICU4X.

Also adds convenience helper functions for CreateDateFromCodes and
CreateDateFrom when the year is in the calendar's standard era.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/01d5670626cb
https://hg.mozilla.org/integration/autoland/rev/6a8030412281
Part 1: Remove calendar-specific maximum year checks. r=spidermonkey-reviewers,mgaudet
https://github.com/mozilla-firefox/firefox/commit/429bd2f2e7bb
https://hg.mozilla.org/integration/autoland/rev/94cc84c0f056
Part 2: Simplify CalendarDateYear. r=spidermonkey-reviewers,mgaudet
https://github.com/mozilla-firefox/firefox/commit/4e6cc4b1acaa
https://hg.mozilla.org/integration/autoland/rev/440cf7fdd127
Part 3: Remove no longer needed code to adjust eras. r=spidermonkey-reviewers,mgaudet

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6a8030412281
https://hg.mozilla.org/mozilla-central/rev/94cc84c0f056
https://hg.mozilla.org/mozilla-central/rev/440cf7fdd127