2012042 - (::before|::after)::marker doesn't support attr()

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: test case

Steps to reproduce

1. Open attached test case

Expected results

Under Hello, there's a * character (coming from content: attr(data-mark, "?") since we have the following markup <div data-mark="*">)

Actual results

Under Hello, there's a ? character (the fallback value of attr() )

Comment 1

[Emilio Cobos Álvarez [:emilio]]

The frame constructor or nsAttrTextNode should walk to the ultimate originating element. Should be an easy fix.

I expect the attr() work Diego and Swarup are doing to eventually fix this as well, once we work on pseudo elements.

Comment 2

[Jonathan Kew [:jfkthame]]

Seems easiest to fix this in nsAttributeTextNode::BindToTree, probably. Trying a simple patch: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=174978

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 2012042 - Make attr() walk to the originating element of a pseudo-element to find the value. r=#dom-core

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4dca853c619a
https://hg.mozilla.org/integration/autoland/rev/7837393122ef
Make attr() walk to the originating element of a pseudo-element to find the value. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57377 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7837393122ef

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot