201215 - {inc}incremental reflow problem for percentage-width float inside table

Status: VERIFIED FIXED

(Core :: Layout: Floats, defect)

Description

[Yisroel Goodman]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0)
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.3) Gecko/20030312

I use the same layout for all my pages yet in mozilla, the blue box which 
contains text randomly changes size.  Sometimes it is so narrow that only a 
word or two fits on a line. If you add items to the shopping cart, the order 
can extend far to the right of the blue box. This does not happen under IE or 
Netscape. To see this, just click menu items to the left at random or view the 
catalog and add items to the shopping cart.

Reproducible: Always

Steps to Reproduce:
1. bring up ygoodman.com
2. click the catalog
3. add items to the cart
4. refresh the cart page or click the credit card order button

Actual Results:  
the blue box becomes narrow and the text extends to the right

Expected Results:  
the blue box is defined as a fixed size and should not change from screen to 
screen

Comment 1

[Boris Zbarsky [:bzbarsky]]

The button is inside a float which is inside a table cell... the table has no
set width.

Looks like clicking the button makes the float become too small (as do the table
cell and table).

A minimal testcase of that page would be nice....

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase

Click the button to see the incremental reflow bug.

Comment 3

[Jesiah S]

I see it on LInux 2003041008 using the Testcase

Comment 4

[Boris Zbarsky [:bzbarsky]]

Bernd, any thoughts?

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This (like the table-in-absolutely-positioned-element bugs) is one of the many
things that should go away if we refactor our shrink wrapping.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This is basically identical to bug 199206

Comment 7

[Boris Zbarsky [:bzbarsky]]

er, wrong bug.

Comment 8

[:aceman]

Very similar to bug 305301, just that here the width declaration is not honored too... Any bug dependancy?

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061208 Minefield/3.0a1 ID:2006120812 [cairo]

fixed by reflow branch landing

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fixed on trunk by reflow branch landing.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: Reftests

Note: This patch assumes that the test for bug 185388 was already checked in with respect to reftest.list

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 257474 [details] [diff] [review]
Reftests

>@@ -67,17 +67,16 @@

Whatever tool you used to generate this patch is broken; the patch is removing 16 lines and adding 17, so these headers need to be reversed.  (Or did you edit by hand?)

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 257474 [details] [diff] [review]
Reftests

Checked in after testing in pre- and post-reflow-branch builds.