2012519 - Replace usage of `newtab-toast-dismiss-button` with a new set of strings

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

I see that the newtab-toast-dismiss-button string is used here: https://searchfox.org/firefox-main/rev/69888f58354c8d44e854945761a9e8fa954512d1/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/PersonalizedCard/PersonalizedCard.jsx#39

However, that string was removed in bug 1998975. We need to either replace this string with it's label and aria-label. It might be worth making its identifier more generic for the various messages we're likely to display inline on newtab, rather than it being toast-centric.

Comment 1

[dgrant]

Whiteboard: [hnt]

Comment 2

[dgrant]

Attachment: Bug 2012519 - Replace usage of newtab-toast-dismiss-button

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b31cd1b1bce9
https://hg.mozilla.org/integration/autoland/rev/d581d53bfb2e
Replace usage of newtab-toast-dismiss-button r=home-newtab-reviewers,reemhamz,fluent-reviewers,bolsson

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d581d53bfb2e