1998975 - Remove Thumbs Up/Down feature from newtab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P2)

Description

[Maxx Crawford [:maxx]]

This feature is heavily embedded in the card UI for both grid and sections layout.

Note that there are some small layout adjustments tied to thumbs up/down being enabled. You'll want to (most likely) port these styles over to the main design.

(You can also see the small differences by toggling the pref browser.newtabpage.activity-stream.discoverystream.thumbsUpDown.enabled)

Be sure to remove:

• Helper classes in base.jsx
• Telemetry (including metrics)
• Tests that have thumbs data as an expected prop
• Prefs

Comment 1

[Maxx Crawford [:maxx]]

Once this is complete, you can close the following bugs:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1921509
• https://bugzilla.mozilla.org/show_bug.cgi?id=1932242
• https://bugzilla.mozilla.org/show_bug.cgi?id=1945528
• https://bugzilla.mozilla.org/show_bug.cgi?id=1991716

(There may be more thumbs related bugs, but these were the ones I quickly found!)

Comment 2

[dgrant]

Attachment: Bug 1998975 Remove thumbs up/down functionality from Discovery Stream cards r?#home-newtab-reviewers,nbarrett

Comment 3

[dgrant]

Attachment: Bug 1998975 Remove thumbs up/down functionality from Discovery Stream cards r?#home-newtab-reviewers,nbarrett

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7429b0fcf10
https://hg.mozilla.org/integration/autoland/rev/dab18ca66123
Remove thumbs up/down functionality from Discovery Stream cards r=nbarrett,home-newtab-reviewers,desktop-theme-reviewers,maxx,tgiles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ddd3820f7adf
https://hg.mozilla.org/integration/autoland/rev/e06a280306fc
Revert "Bug 1998975 Remove thumbs up/down functionality from Discovery Stream cards r=nbarrett,home-newtab-reviewers,desktop-theme-reviewers,maxx,tgiles" for causing failures on browser_all_files_referenced.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing failures on browser_all_files_referenced.

Push with failures

Failure log

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d8ee2e712075
https://hg.mozilla.org/integration/autoland/rev/e9477ec4718c
Remove thumbs up/down functionality from Discovery Stream cards r=nbarrett,home-newtab-reviewers,desktop-theme-reviewers,maxx,tgiles

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/dab18ca66123

Comment 9

[Cosmin Sabou [:CosminS]]

Will be fixed when comment 7 merges to central.

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e9477ec4718c

Comment 11

[dgrant]

(In reply to Cosmin Sabou [:CosminS] from comment #6)

Backed out for causing failures on browser_all_files_referenced.

Push with failures

Failure log

Backout link