2012536 - Implement Tab switching state mgmt for chat sessions (full/sidebar)

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task, P1)

Description

[:omarg]

Implement state management for switching tabs to update the sidebar/fullwindow state of the chat session

• switching tabs should render the correct conversation (or not display a conversation) in both full/sidebar states
• switching tabs should keep state on the chat input

Comment 1

[Ed Lee :Mardak]

bug 2011266 is adding some sidebar context watching for location change

Comment 2

[:omarg]

Attachment: Bug 2012536 - Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1a3dc6a1022
https://hg.mozilla.org/integration/autoland/rev/f9a78df0164a
Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3bdcfec24d20
https://hg.mozilla.org/integration/autoland/rev/26a3129fc6d3
Revert "Bug 2012536 - Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers" for causing multiple failures @ browser_open_in_lazy_tab.js / browser_bug_1387976_restore_lazy_tab_browser_muted_state.js / browser_restore_container_tabs_oa.js / browser_ext_tabs_discard_reversed.js

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures @ browser_open_in_lazy_tab.js / browser_bug_1387976_restore_lazy_tab_browser_muted_state.js / browser_restore_container_tabs_oa.js / browser_ext_tabs_discard_reversed.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/26a3129fc6d34a6843ec952659f4f2b747f2193e

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_bug_1387976_restore_lazy_tab_browser_muted_state.js | Restored tab should not be inserted

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_restore_container_tabs_oa.js

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_open_in_lazy_tab.js | open_customize_mode_in_lazy_tab - Tab should be lazy - Got "panel-3-247", expected null

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_discard_reversed.js | tabs_discarded_load_and_discard - Tab initially discarded

Comment 6

[:omarg]

I made changes that fix the failures for browser_open_in_lazy_tab.js / browser_bug_1387976_restore_lazy_tab_browser_muted_state.js / browser_restore_container_tabs_oa.js.

The failures in browser_ext_tabs_discard_reversed.js I was able to replicate in the main branch, where it failed most of the time but did pass twice, but I tried several times to clobber my build, and re-run tests and I kept getting failures for the tests in this file on main.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a14cdfa84f30
https://hg.mozilla.org/integration/autoland/rev/b13467d44dbd
Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b1264e3cfde3
https://hg.mozilla.org/integration/autoland/rev/a9445a878f80
Revert "Bug 2012536 - Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers" for causing failures at browser_chats_firefoxview.js

Comment 9

[Atila Butkovits]

Backed out for causing failures at browser_chats_firefoxview.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/a9445a878f80b48ca4a1dd9b2e0d73a1601e6c04

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PbjiFKgfQQa8piepHOsiwQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b13467d44dbd4179cb7df3acaee0508de8af22b4

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=547557343&repo=autoland&task=O9vSZAShSXypXjKtKODLTw.0&lineNumber=3291
https://treeherder.mozilla.org/logviewer?job_id=547557439&repo=autoland&task=GPDwbPhwTdu4oQvGwu7m4g.0&lineNumber=11817

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f281139eec62
https://hg.mozilla.org/integration/autoland/rev/9eb6ce1b0fdf
Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/902d6641cc26
https://hg.mozilla.org/integration/autoland/rev/665550b1988f
Revert "Bug 2012536 - Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers" for causing bc failures @browser_smartwindow_tab_switching.js.

Comment 12

[agoloman]

Backed out for causing bc failures @browser_smartwindow_tab_switching.js.

• Backout link
• Push with failures
• Failure Log

Comment 13

[:omarg]

Fixed the leaky tabs/window in browser_smartwindow_tab_switching.js.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9036102bc1f5
https://hg.mozilla.org/integration/autoland/rev/78ab81c0aeff
Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2d196e0537b5
https://hg.mozilla.org/integration/autoland/rev/e8b50b04ec37
Revert "Bug 2012536 - Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers" for causing bc failures @browser_smartwindow_tab_switching.js.

Comment 16

[agoloman]

Backed out for causing bc failures @browser_smartwindow_tab_switching.js.

• Backout link
• Push with failures
• Failure Log

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e2d7168d252
https://hg.mozilla.org/integration/autoland/rev/e6e90dd83317
Implement tab switching for smart window sidebar state mgmt r=Mardak,ai-frontend-reviewers

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e6e90dd83317

Comment 19

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 149.0b1