2022050 - fetching ai response inconsistently checks adjacent tab at various times

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect)

Description

[Ed Lee :Mardak]

we might end up sending/saving the wrong tab/page information

bug 2012536 gets the current page when fetching ai response

https://searchfox.org/firefox-main/rev/7b1a35d6c70c08d2966c6c8dfc9aa9c04319f721/browser/components/aiwindow/ui/components/ai-window/ai-window.mjs#856,921-924,942,961

whereas bug 2011266 populates context chips with the current tab

https://searchfox.org/firefox-main/rev/7b1a35d6c70c08d2966c6c8dfc9aa9c04319f721/browser/components/urlbar/content/SmartbarInput.mjs#6229,6237

we probably want to unify on one as the source of truth not dependent on the specific timing of when we fetch or for other uses like for bug 2015919

Comment 1

[:Gijs (he/him)]

To be clear this can lead to the LLM summarizing the wrong tab / being given information the user did not expect the LLM to have.

Comment 2

[:omarg]

Attachment: Bug 2022050 - normalize current tab url querying for chat and context chips r=#ai-frontend-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/03cc7c153be1
https://hg.mozilla.org/integration/autoland/rev/e0455e9c6501
normalize current tab url querying for chat and context chips r=ai-frontend-reviewers,urlbar-reviewers,ai-models-reviewers,Mardak,jteow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f832494ff471
https://hg.mozilla.org/integration/autoland/rev/5f885a404c3d
Revert "Bug 2022050 - normalize current tab url querying for chat and context chips r=ai-frontend-reviewers,urlbar-reviewers,ai-models-reviewers,Mardak,jteow" for causing bc failures at browser_smartwindow_context_url.js

Comment 5

[rperta]

Backed out for causing bc failures at browser_smartwindow_context_url.js
Backout link
Push with failures
Failure log(s)
Failure log(s)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9510ecfd5402
https://hg.mozilla.org/integration/autoland/rev/6d3e8246b98c
normalize current tab url querying for chat and context chips r=ai-frontend-reviewers,urlbar-reviewers,ai-models-reviewers,Mardak,jteow

Comment 7

[:omarg]

Fixed a test that needed more updates.
Fixed some window leaks from unresolved async calls in browser_smartwindow_context_url.js

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6d3e8246b98c

Comment 9

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Required for Smart Window Feature Fx150 MVP launch.

Comment 10

[Punam Dahiya [:pdahiya]]

NI @rdoghi to help QA in Nightly Fx151 before uplifting to beta @Omar will be great if you can add test steps in bug or patch for fix verification thanks!

Comment 11

[:omarg]

I'm not sure how to best verify this from the interface side.

The bug was to ensure that all LLM requests that are triggered from a user's prompt always reference the currently selected tab as was selected at the time of prompting.

Before the changes different parts of the code would directly access the browser's selected tab, which could potentially change after submitting the user prompt.

I suppose the only thing that would potentially surface to the interface was if the conversation response from the LLM referenced an incorrect tab, but I don't have reliable way to reproduce that.

Comment 12

[Rares Doghi, Desktop QA]

Hi, I tried to reproduce this issue but without success, all I can say is that in our latest builds the correct tab is being summarized even though I tried switching tabs between submitting a prompt, each time the current active tab was summarized. Im not sure if I should mark this Verified since I wasnt able to reproduce this issue to begin with but maybe somebody else can close it. Based on our latest builds this issue is Verified as fixed.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:omarg, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[:omarg]

Attachment: Bug 2022050 - normalize current tab url querying for chat and context chips

Original Revision: https://phabricator.services.mozilla.com/D288576

Comment 15

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Potential to submit wrong tab data during a conversation, which could expose private data the user did not intend to submit to an LLM backend in the course of a Smart Window chat conversation.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: 1. Open Smart Window

2. Navigate to a URL
3. Open a second tab, navigate to a different URL
4. Start a conversation in the tab on the second site, asking it to summarize the page or something that would respond using context of the current page
5. Immediately after pressing Enter try switching to the first tab
6. Switch back to the second tab where the conversation was started
7. The summary should always be based on the tab/site adjacent to the chat when the tab is chosen

Note: This was an edge case that was hard to replicate in UI, but a possibility based on the code implementation. The patch removes accessing the selectedTab's URL at various points in the lifetime of an LLM prompt, making sure it only takes the selectedTab's URL when the prompt is submitted by the user.

• Risk associated with taking this patch: low
• Explanation of risk level: Does not affect the user experience of chat. Does not change the underlying integrations with the LLM backend, just reduces times the LLM response cycle tries to access the selectedTab's URL to one, at prompt submission.
• String changes made/needed?: None.
• Is Android affected?: no

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d7c596a4bc8b
https://hg.mozilla.org/releases/mozilla-beta/rev/71f75f8c329e

Comment 17

[Rares Doghi, Desktop QA]

Verified as fixed in our latest BEta 150.0b4 and our latest Nightly build 151.0a1 (2026-03-30)